Re: [Qemu-devel] Re: [PATCH] pc: e820 qemu_cfg tables need to be packed

[Anthony Liguori <anthony@codemonkey.ws>]

On 10/14/2010 02:58 PM, Alex Williamson wrote:
> On Thu, 2010-10-14 at 14:48 -0500, Anthony Liguori wrote:
>    
>> On 10/14/2010 02:44 PM, Jes Sorensen wrote:
>>      
>>> On 10/14/10 20:33, Alex Williamson wrote:
>>>
>>>        
>>>> We can't let the compiler define the alignment for qemu_cfg data.
>>>>
>>>> Signed-off-by: Alex Williamson<alex.williamson@redhat.com>
>>>> ---
>>>>
>>>> 0.13 stable candidate?
>>>>
>>>>          
>>> ACK I would say so.
>>>
>>>        
>> fw_cfg interfaces are somewhat difficult to rationalize about for
>> compatibility.
>>
>> 0.13.0 is tagged already so it's too late to pull it in there.  If we
>> say we don't care about compatibility at the fw_cfg level, then it
>> doesn't matter if we pull it into stable-0.13.  If we do care, then this
>> is an ABI breaker.
>>      
> If it works anywhere (I assume it works on 32bit), then it's only
> because it happened to get the alignment right.  This just makes 64bit
> hosts get it right too.  I don't see any compatibility issues,
> non-packed + 64bit = broken.  Thanks,
>    

Ok, I'll buy that argument :-)

Regards,

Anthony Liguori

> Alex
>
>