Hi Petteri,

On 10/14/2010 04:02 PM, Petteri Tikander wrote:
> Handling of new parameter (file status) from the driver added.
> This commit doesn't store EF-info into cache yet.

Please keep your commit header to less than 50 characters.

> +	if (op->info_only) {
> +		/*
> +		 * It's info-only request. So there is no need to request
> +		 * actual contents of the EF-files. Just return the EF-info.
> +		 */
> +		cb(1, op->length, op->current,
> +			&file_status, op->record_length, op->userdata);
> +

So I honestly don't like us using the ofono_sim_file_read_cb_t for the
callback in the info only case.  Can we invent a new callback type
specifically for this case?

Regards,
-Denis