All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Karsten Keil <isdn@linux-pingi.de>,
	Armin Schindler <mac@melware.de>,
	lkml <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: [PATCH v2.6.36-rc7] isdn/eicon: don't call flush_scheduled_work() from diva_os_remove_soft_isr()
Date: Fri, 15 Oct 2010 14:57:19 +0200	[thread overview]
Message-ID: <4CB84FAF.5080608@kernel.org> (raw)

diva doesn't use workqueue and there is no reason to flush the system
workqueue from diva_os_remove_soft_isr().  Remove it.

This is to prepare for the deprecation and removal of
flush_scheduled_work().

Signed-off-by: Tejun Heo <tj@kernel.org>
---
 drivers/isdn/hardware/eicon/divasmain.c |    2 --
 1 file changed, 2 deletions(-)

Index: work/drivers/isdn/hardware/eicon/divasmain.c
===================================================================
--- work.orig/drivers/isdn/hardware/eicon/divasmain.c
+++ work/drivers/isdn/hardware/eicon/divasmain.c
@@ -15,7 +15,6 @@
 #include <asm/uaccess.h>
 #include <asm/io.h>
 #include <linux/ioport.h>
-#include <linux/workqueue.h>
 #include <linux/pci.h>
 #include <linux/interrupt.h>
 #include <linux/list.h>
@@ -546,7 +545,6 @@ void diva_os_remove_soft_isr(diva_os_sof
 		void *mem;

 		tasklet_kill(&pdpc->divas_task);
-		flush_scheduled_work();
 		mem = psoft_isr->object;
 		psoft_isr->object = NULL;
 		diva_os_free(0, mem);

             reply	other threads:[~2010-10-15 12:57 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-15 12:57 Tejun Heo [this message]
2010-10-16 12:42 ` [PATCH v2.6.36-rc7] isdn/eicon: don't call flush_scheduled_work() from diva_os_remove_soft_isr() Armin Schindler
2010-10-16 13:11   ` Tejun Heo
2010-10-16 22:32     ` Armin Schindler
2010-10-17  9:26       ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CB84FAF.5080608@kernel.org \
    --to=tj@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=isdn@linux-pingi.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mac@melware.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.