From: James Carlson <carlsonj@workingcode.com>
To: linux-ppp@vger.kernel.org
Subject: Re: [PATCH] pppoe: Missed check for destination addr in PADT frame
Date: Fri, 15 Oct 2010 13:31:53 +0000 [thread overview]
Message-ID: <4CB857C9.9080703@workingcode.com> (raw)
In-Reply-To: <AANLkTim5m4f-7U4kMghBR0yEQka3-iOaJ9aHwf4sGsxj@mail.gmail.com>
On 10/15/10 08:38, Leonid Lisovskiy wrote:
> PADT h_source\0:11:95:fc:83:f3 h_dest: 00:0e:08:2f:da:c5 session_id: 1
> PADT h_source\0:11:95:fc:83:f3 h_dest: 00:14:85:03:da:49 session_id: 1
Wow, that's wacky. Thanks for the data point. I've never seen that
behavior before.
For what it's worth, I think there's nothing specifically wrong with
that behavior, so I'd say it's a bit of a stretch calling it a bug. The
session ID is for the server to use in demuxing; if it can demux without
it, then using 1 for everything doesn't violate anything I can see.
"Normal" clients should not be seeing unicast packets sent to anything
other than their own MAC address -- they should get filtered out at the
MAC layer before PPPoE ever has a chance to see them. So the reuse
should be invisible.
If you're not filtering for your own MAC address on unicast reception,
I'd be a little concerned that there are other places where the
protocols go awry, and not just PADT. This might be something to look into.
--
James Carlson 42.703N 71.076W <carlsonj@workingcode.com>
prev parent reply other threads:[~2010-10-15 13:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-13 12:33 [PATCH] pppoe: Missed check for destination addr in PADT frame processing Leonid Lisovskiy
2010-10-15 10:32 ` Leonid Lisovskiy
2010-10-15 10:34 ` Sujit K M
2010-10-15 10:51 ` Sujit K M
2010-10-15 11:11 ` Leonid Lisovskiy
2010-10-15 11:49 ` [PATCH] pppoe: Missed check for destination addr in PADT frame James Carlson
2010-10-15 12:38 ` [PATCH] pppoe: Missed check for destination addr in PADT frame processing Leonid Lisovskiy
2010-10-15 13:31 ` James Carlson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CB857C9.9080703@workingcode.com \
--to=carlsonj@workingcode.com \
--cc=linux-ppp@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.