From: Tejun Heo <tj@kernel.org>
To: Robert Richter <robert.richter@amd.com>,
oprofile-list@lists.sf.net, lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2.6.36-rc7] oprofile: don't use flush_scheduled_work()
Date: Fri, 15 Oct 2010 15:53:52 +0200 [thread overview]
Message-ID: <4CB85CF0.1040900@kernel.org> (raw)
In-Reply-To: <4CB85C4C.6080806@kernel.org>
On 10/15/2010 03:51 PM, Tejun Heo wrote:
> flush_scheduled_work() is deprecated and scheduled to be removed.
> sync_stop() currently cancels cpu_buffer works inside buffer_mutex and
> flushes the system workqueue outside. Instead, split end_cpu_work()
> into two parts - stopping further work enqueues and flushing works -
> and do the former inside buffer_mutex and latter outside.
>
> Signed-off-by: Tejun Heo <tj@kernel.org>
Ooh, BTW, the global symbols in cpu_buffer seem a bit too generic. I
don't think oprofile should be defining alloc/free_cpu_buffers() and
start/end/flush_cpu_work(). Maybe it would be a good idea to add op_
prefix to them?
Thanks.
--
tejun
next prev parent reply other threads:[~2010-10-15 13:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-15 13:51 [PATCH v2.6.36-rc7] oprofile: don't use flush_scheduled_work() Tejun Heo
2010-10-15 13:53 ` Tejun Heo [this message]
2010-10-29 10:03 ` Robert Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CB85CF0.1040900@kernel.org \
--to=tj@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oprofile-list@lists.sf.net \
--cc=robert.richter@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.