From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=46068 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1P6mdB-00054n-U1
	for qemu-devel@nongnu.org; Fri, 15 Oct 2010 11:55:43 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1P6md5-0000PN-LF
	for qemu-devel@nongnu.org; Fri, 15 Oct 2010 11:55:36 -0400
Received: from mx1.redhat.com ([209.132.183.28]:50219)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1P6md5-0000PD-F5
	for qemu-devel@nongnu.org; Fri, 15 Oct 2010 11:55:35 -0400
Message-ID: <4CB87993.1050102@redhat.com>
Date: Fri, 15 Oct 2010 17:56:03 +0200
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
References: <1287061278-17908-1-git-send-email-kwolf@redhat.com>
	<20101015145725.GA16016@lst.de>
In-Reply-To: <20101015145725.GA16016@lst.de>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH][qemu-iotests] Improve test for qemu-img
 convert with backing file
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Christoph Hellwig <hch@lst.de>
Cc: qemu-devel@nongnu.org

Am 15.10.2010 16:57, schrieb Christoph Hellwig:
> On Thu, Oct 14, 2010 at 03:01:18PM +0200, Kevin Wolf wrote:
>> Additionally to testing the qemu-img convert -B option, also test
>> -o backing_file.
>>
>> Also, the old test acidentlly used a pattern of zeros for most of the writes,
>> so that the allocation test didn't really work out. This is fixed by using an
>> explicit pattern.
>>
>> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
>> ---
>>  019 |   59 ++++++++++++++++++++++++++++++++++++-----------------------
>>  1 files changed, 36 insertions(+), 23 deletions(-)
> 
> It's missing the update to the golden output an now fails.

Oops... Will send a new version.

> Btw, did you change the qemu-img check to tell people that leaked
> clusters are harmless?  That message causes 026 to fail for me with a
> recent qemu-img.

Didn't I send a patch for qemu-iotests, too? I do have local commit
updating this at least.

Kevin