[Qemu-devel] Re: [PATCH 0/9] Re-factor osdep code + macro and brace fixes

[Paolo Bonzini <pbonzini@redhat.com>]

On 10/15/2010 04:05 PM, Jes.Sorensen@redhat.com wrote:
> From: Jes Sorensen<Jes.Sorensen@redhat.com>
>
> Hi,
>
> Here is another set of patches which tries to split up osdep.c further
> into posix and win32 versions. It introduces os-{posix,win32}-lib.c
> files which are used for functions that are OS specific core library
> functionality, like gettimeofday(), and which is used by both QEMU and
> support applications like qemu-img. Other functions are moved to
> os-{posix,win32}.c. In addtion there are a couple of minor fixes for
> bad macro names.
>
> In some cases braces were added to code when it was moved, to make it
> compliant with the QEMU bracing rules.
>
> Cheers,
> Jes
>
>
> Jes Sorensen (9):
>    Move QEMU OS dependant library functions to OS specific files
>    Move osdep socket code to os-{posix,win32}-lib.c
>    qemu_pipe() is used only by POSIX code, so move to os-posix-lib.c
>    We only support eventfd under POSIX, move qemu_eventfd() to
>      os-posix.c
>    Move qemu_gettimeofday() to OS specific files
>    Do not redefine reserved key-words TRUE/FALSE
>    Separate qemu_pidfile() into OS specific versions
>    Consolidate oom_check() functions
>    Remove unncessary includes
>
>   Makefile           |    6 +-
>   Makefile.objs      |    9 ++-
>   hw/bt-sdp.c        |   21 +++--
>   os-posix-lib.c     |  111 +++++++++++++++++++++++
>   os-posix.c         |   53 +++++++++++
>   os-win32-lib.c     |  128 ++++++++++++++++++++++++++
>   os-win32.c         |   24 +++++
>   osdep.c            |  256 ----------------------------------------------------
>   osdep.h            |   15 ---
>   posix-aio-compat.c |    1 +
>   qemu-common.h      |    1 +
>   qemu-img.c         |    1 +
>   qemu-malloc.c      |   14 +---
>   qemu-os-posix.h    |    3 +
>   qemu-os-win32.h    |    9 ++
>   qemu-tool.c        |    1 +
>   16 files changed, 357 insertions(+), 296 deletions(-)
>   create mode 100644 os-posix-lib.c
>   create mode 100644 os-win32-lib.c
>

ACK except for the nit in patch 5/9.

Paolo