From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Lord Subject: Re: [PATCH #upstream-fixes] libahci: fix result_tf handling after an ATA PIO data-in command Date: Fri, 15 Oct 2010 18:14:02 -0400 Message-ID: <4CB8D22A.4010307@teksavvy.com> References: <4C9C3878.9010206@teksavvy.com> <4C9C44D0.1030409@teksavvy.com> <4C9CA385.5090709@teksavvy.com> <4C9CA673.4090104@teksavvy.com> <4C9D33C0.8050900@gmail.com> <4CA99BCB.8080904@gmail.com> <4CAA0885.8060906@teksavvy.com> <4CAA0996.5080403@teksavvy.com> <4CAA0F6C.6080609@teksavvy.com> <4CAA21F4.5060000@teksavvy.com> <4CAA2AA6.2010204@pobox.com> <4CAA2C6F.2090603@teksavvy.com> <4CAA2E16.4010905@pobox.com> <4CAA3033.8030405@teksavvy.com> <4CAACEBE.1000104@gmail.com> <4CAB30FA.2010508@teksavvy.com> <4CAB4CE9.9070709@gmail.com> <4CB6C50F.60609@kernel.org> <4CB7783A.2050604@teksavvy.com> <4CB814C2.6030404@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from ironport2-out.teksavvy.com ([206.248.154.181]:42284 "EHLO ironport2-out.pppoe.ca" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751133Ab0JOWOT (ORCPT ); Fri, 15 Oct 2010 18:14:19 -0400 In-Reply-To: <4CB814C2.6030404@kernel.org> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Tejun Heo Cc: Robert Hancock , Jeff Garzik , Seed , IDE/ATA development list , stable@kernel.org On 10-10-15 04:45 AM, Tejun Heo wrote: > On 10/15/2010 02:24 AM, Robert Hancock wrote: >>> I'm not certain, but doesn't this problem also affect DMA_TO_DEVICE PIO >>> commands? >>> Eg. SECURITY_ERASE_PREPARE and PIO_WRITE ? >> >> No, PIO data-out commands send a D2H register FIS after completion. It >> appears that PIO data-in is the only special case. > > Yeap, it's an exception only for PIO data-in's. Peachy. Thanks for working on this. I'm away from my setup right now, but will test as soon as I get back. In the meanwhile, feel free to nag if you don't hear back by Mon/Tues. Cheers