From: Dimitris Michailidis <dm@chelsio.com>
To: Stephen Hemminger <shemminger@vyatta.com>
Cc: Divy Le Ray <divy@chelsio.com>,
"David S. Miller" <davem@davemloft.net>,
Casey Leedom <leedom@chelsio.com>,
netdev@vger.kernel.org, Steve Wise <swise@opengridcomputing.com>
Subject: Re: [PATCH 2/3] cxgb4: function namespace cleanup (v2)
Date: Fri, 15 Oct 2010 23:16:45 -0700 [thread overview]
Message-ID: <4CB9434D.1060702@chelsio.com> (raw)
In-Reply-To: <20101015212310.47a74d86@nehalam>
Stephen Hemminger wrote:
> On Fri, 15 Oct 2010 18:11:42 -0700
> Dimitris Michailidis <dm@chelsio.com> wrote:
>
>> Stephen Hemminger wrote:
>>> Make functions only used in one file local.
>>> Remove lots of dead code, relating to unsupported functions
>>> in mainline driver like RSS, IPv6, and TCP offload.
>> Thanks, this looks OK. One exception, cxgb4_get_tcp_stats was intended to
>> be used by the rdma driver. I see that driver doesn't call it presently but
>> if you don't mind can we give Steve a few hours to tell us if he has any
>> imminent plans to use it. If he doesn't offer to do something to use it for
>> .37 it goes.
>
> The kernel source tree is not your development place holder tree.
> At least #ifdef the code out for now.
I am trying to protect Stephen Rothwell's time by checking that the IB folks
don't plan to add a call to this in their tree while we remove the function
in net-next. There's supposed to be a call in the IB driver. I don't know
why there isn't one or whether they are planning to fix it for .37. I see
the potential for a linux-next conflict and I am trying to avoid it. #ifdef
doesn't help, if it's not needed we can remove it for good.
next prev parent reply other threads:[~2010-10-16 6:16 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-15 22:43 [PATCH 0/3] Chelsio driver namespace cleanups Stephen Hemminger
2010-10-15 22:43 ` [PATCH 1/3] cxgb3: function namespace cleanup Stephen Hemminger
2010-10-19 1:14 ` Divy Le Ray
2010-10-21 14:19 ` David Miller
2010-10-15 22:43 ` [PATCH 2/3] cxgb4: " Stephen Hemminger
2010-10-15 23:29 ` Joe Perches
2010-10-15 23:50 ` Stephen Hemminger
2010-10-15 23:34 ` Dimitris Michailidis
2010-10-16 0:10 ` [PATCH 2/3] cxgb4: function namespace cleanup (v2) Stephen Hemminger
2010-10-16 1:11 ` Dimitris Michailidis
2010-10-16 4:23 ` Stephen Hemminger
2010-10-16 6:16 ` Dimitris Michailidis [this message]
2010-10-17 3:30 ` Steve Wise
2010-10-18 14:31 ` David Miller
2010-10-18 15:39 ` [PATCH 2/3] cxgb4: function namespace cleanup (v3) Stephen Hemminger
2010-10-18 23:16 ` Dimitris Michailidis
2010-10-21 11:30 ` David Miller
2010-10-18 14:47 ` [PATCH 2/3] cxgb4: function namespace cleanup (v2) Stephen Hemminger
2010-10-18 14:53 ` Steve Wise
2010-10-15 22:43 ` [PATCH 3/3] cxgb4vf: function namespace cleanup Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CB9434D.1060702@chelsio.com \
--to=dm@chelsio.com \
--cc=davem@davemloft.net \
--cc=divy@chelsio.com \
--cc=leedom@chelsio.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
--cc=swise@opengridcomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.