From: Jan Kiszka <jan.kiszka@web.de>
To: Tejun Heo <tj@kernel.org>
Cc: Karsten Keil <isdn@linux-pingi.de>,
Armin Schindler <mac@melware.de>,
lkml <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH v2.6.36-rc7 1/2] isdn/capi: unregister capictr notifier after init failure
Date: Sat, 16 Oct 2010 13:00:11 +0200 [thread overview]
Message-ID: <4CB985BB.5080804@web.de> (raw)
In-Reply-To: <4CB84C4C.6040204@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 857 bytes --]
Am 15.10.2010 14:42, Tejun Heo wrote:
> capidrv_init() could leave capictr notifier dangling after init
> failure. Fix it.
Good catch!
I assume David will pick these two up for net-next. Adding him to CC.
Acked-by: Jan Kiszka <jan.kiszka@web.de>
>
> Signed-off-by: Tejun Heo <tj@kernel.org>
> ---
> drivers/isdn/capi/capidrv.c | 1 +
> 1 file changed, 1 insertion(+)
>
> Index: work/drivers/isdn/capi/capidrv.c
> ===================================================================
> --- work.orig/drivers/isdn/capi/capidrv.c
> +++ work/drivers/isdn/capi/capidrv.c
> @@ -2288,6 +2288,7 @@ static int __init capidrv_init(void)
>
> errcode = capi20_get_profile(0, &profile);
> if (errcode != CAPI_NOERROR) {
> + unregister_capictr_notifier(&capictr_nb);
> capi20_release(&global.ap);
> return -EIO;
> }
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 259 bytes --]
prev parent reply other threads:[~2010-10-16 11:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-15 12:42 [PATCH v2.6.36-rc7 1/2] isdn/capi: unregister capictr notifier after init failure Tejun Heo
2010-10-15 12:43 ` [PATCH v2.6.36-rc7 2/2] isdn/capi: make kcapi use a separate workqueue Tejun Heo
2010-10-16 11:00 ` Jan Kiszka
2010-10-16 11:00 ` Jan Kiszka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CB985BB.5080804@web.de \
--to=jan.kiszka@web.de \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=isdn@linux-pingi.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mac@melware.de \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.