All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mauro Carvalho Chehab <mchehab@infradead.org>
To: Daniel Drake <dsd@laptop.org>
Cc: Jonathan Corbet <corbet@lwn.net>, linux-media@vger.kernel.org
Subject: Re: [PATCH 2/3] ov7670: disable QVGA mode
Date: Sat, 16 Oct 2010 09:55:55 -0300	[thread overview]
Message-ID: <4CB9A0DB.6060203@infradead.org> (raw)
In-Reply-To: <AANLkTi=G_k6CSy9wUTiXNK9DHPwk4FTqPWRReRC7DO24@mail.gmail.com>

Em 08-10-2010 18:18, Daniel Drake escreveu:
> On 8 October 2010 22:13, Jonathan Corbet <corbet@lwn.net> wrote:
>> A problem like that will be at the controller level, not the sensor
>> level.  Given that this is an XO-1 report, I'd assume something
>> requires tweaking in the cafe_ccic driver.  I wasn't aware of this; I
>> know it worked once upon a time.
> 
> I reported it 3 months ago
> http://dev.laptop.org/ticket/10231
> 
> Are you interested in working on this?
> I'd have no idea where to start.

It maybe at one or at the other. What happens is that, in general, both the controller
and the sensor discards the initial/final parts of a line. The visible area of the image
is (generally) configurable on both. If the visible area doesn't match, you'll see a vertical
or a horizontal line.

This is configured by hstart and hstop, in the case of ov sensors. If you wanna try to fix, all 
you need to do is do move the start/stop window, for example, subtracting 2 on both hstart/hstop. 
If this doesn't fix, try 3, 4, ...

Yet, as Jon mentioned, if this works on XO-1, the better fix would be to adjust the screen visible
area at XO-2 visible area setup (sometimes called "crop area" at datasheets).


> 
> I'm not so convinced that it's a controller problem rather than a
> sensor one, given that it says the sensor register values were
> determined empirically rather than from docs.
> 
> Thanks,
> Daniel
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html


      reply	other threads:[~2010-10-16 12:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-08 21:04 [PATCH 2/3] ov7670: disable QVGA mode Daniel Drake
2010-10-08 21:13 ` Jonathan Corbet
2010-10-08 21:18   ` Daniel Drake
2010-10-16 12:55     ` Mauro Carvalho Chehab [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CB9A0DB.6060203@infradead.org \
    --to=mchehab@infradead.org \
    --cc=corbet@lwn.net \
    --cc=dsd@laptop.org \
    --cc=linux-media@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.