From: Felix Fietkau <nbd@openwrt.org>
To: Rajkumar Manoharan <rmanoharan@atheros.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"linville@tuxdriver.com" <linville@tuxdriver.com>,
Luis Rodriguez <Luis.Rodriguez@Atheros.com>
Subject: Re: [PATCH 1/6] ath9k_hw: optimize interrupt mask changes
Date: Sat, 16 Oct 2010 15:10:11 +0200 [thread overview]
Message-ID: <4CB9A433.5050007@openwrt.org> (raw)
In-Reply-To: <20101016115041.GA4028@vmraj-lnx.users.atheros.com>
On 2010-10-16 1:51 PM, Rajkumar Manoharan wrote:
> On Fri, Oct 15, 2010 at 11:33:28PM +0530, Felix Fietkau wrote:
>> @@ -751,8 +751,8 @@ chip_reset:
>> ath_debug_stat_interrupt(sc, status);
>>
>> if (sched) {
>> - /* turn off every interrupt except SWBA */
>> - ath9k_hw_set_interrupts(ah, (ah->imask & ATH9K_INT_SWBA));
>> + /* turn off every interrupt */
>> + ath9k_hw_disable_interrupts(ah);
>
> won't it affect beacon generation?
No, because the original code did not leave SWBA interrupts enabled
either, as it was masking out ATH9K_INT_GLOBAL. So far I haven't seen
issues with beacons under high load, even on slow embedded hardware.
- Felix
next prev parent reply other threads:[~2010-10-16 13:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-15 18:03 [PATCH 1/6] ath9k_hw: optimize interrupt mask changes Felix Fietkau
2010-10-15 18:03 ` [PATCH 2/6] ath9k_hw: small optimization in ar9002_hw_get_isr Felix Fietkau
2010-10-15 18:03 ` [PATCH 3/6] ath9k_hw: optimize tx status descriptor processing Felix Fietkau
2010-10-15 18:03 ` [PATCH 4/6] ath9k: optimize/fix ANI RSSI processing Felix Fietkau
2010-10-15 18:03 ` [PATCH 5/6] ath9k: remove a redundant call to ath9k_hw_gettsf32 Felix Fietkau
2010-10-15 18:03 ` [PATCH 6/6] ath9k_hw: make ath9k_hw_gettsf32 static Felix Fietkau
2010-10-18 1:24 ` [PATCH 4/6] ath9k: optimize/fix ANI RSSI processing Bruno Randolf
2010-10-18 1:52 ` Felix Fietkau
2010-10-16 11:51 ` [PATCH 1/6] ath9k_hw: optimize interrupt mask changes Rajkumar Manoharan
2010-10-16 13:10 ` Felix Fietkau [this message]
2010-11-08 19:54 ` [PATCH v2 " Felix Fietkau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CB9A433.5050007@openwrt.org \
--to=nbd@openwrt.org \
--cc=Luis.Rodriguez@Atheros.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=rmanoharan@atheros.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.