From: Jiri Slaby <jirislaby@gmail.com>
To: Tracey Dent <tdent48227@gmail.com>
Cc: gregkh@suse.de, alan@lxorguk.ukuu.org.uk,
akpm@linux-foundation.org, mhw@wittsend.com, minyard@acm.org,
openipmi-developer@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 02/05] Drivers: char: impi: Makefile: replace the use of <module>-objs with <module>-y
Date: Sat, 16 Oct 2010 18:52:36 +0200 [thread overview]
Message-ID: <4CB9D854.7050806@gmail.com> (raw)
In-Reply-To: <1287235613-1545-2-git-send-email-tdent48227@gmail.com>
On 10/16/2010 03:26 PM, Tracey Dent wrote:
> Changed <module>-objs to <module>-y in Makefile.
>
> Signed-off-by: Tracey Dent <tdent48227@gmail.com>
> ---
> drivers/char/ipmi/Makefile | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/char/ipmi/Makefile b/drivers/char/ipmi/Makefile
> index eb8a1a8..16a9364 100644
> --- a/drivers/char/ipmi/Makefile
> +++ b/drivers/char/ipmi/Makefile
> @@ -2,7 +2,7 @@
> # Makefile for the ipmi drivers.
> #
>
> -ipmi_si-objs := ipmi_si_intf.o ipmi_kcs_sm.o ipmi_smic_sm.o ipmi_bt_sm.o
> +ipmi_si-y := ipmi_si_intf.o ipmi_kcs_sm.o ipmi_smic_sm.o ipmi_bt_sm.o
NACK (and all of these). This will try to build 4 modules instead of
one. Read Documentation/kbuild/makefiles.txt
regards,
--
js
next prev parent reply other threads:[~2010-10-16 16:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-16 13:26 [PATCH 01/05] Drivers: char: ip2: Makefile: replace the use of <module>-objs with <module>-y Tracey Dent
2010-10-16 13:26 ` [PATCH 02/05] Drivers: char: impi: " Tracey Dent
2010-10-16 16:52 ` Jiri Slaby [this message]
2010-10-16 17:00 ` Jiri Slaby
2010-10-16 21:12 ` Tracey Dent
2010-10-16 13:26 ` [PATCH 03/05] Drivers: Char: mwave: Makefile: Makefile clean up Tracey Dent
2010-10-16 13:26 ` [PATCH 04/05] Drivers: char: pcmcia: ipwireless: Makefile: replace the use of <module>-objs with <module>-y Tracey Dent
2010-10-16 13:26 ` [PATCH 05/05] Drivers: char: rio: " Tracey Dent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CB9D854.7050806@gmail.com \
--to=jirislaby@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mhw@wittsend.com \
--cc=minyard@acm.org \
--cc=openipmi-developer@lists.sourceforge.net \
--cc=tdent48227@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.