[Qemu-devel] Re: [PATCH v2][qemu-iotests] Improve test for qemu-img convert with backing file

[Kevin Wolf <kwolf@redhat.com>]

Am 15.10.2010 23:11, schrieb Christoph Hellwig:
> On Fri, Oct 15, 2010 at 06:05:39PM +0200, Kevin Wolf wrote:
>> Additionally to testing the qemu-img convert -B option, also test
>> -o backing_file.
>>
>> Also, the old test acidentlly used a pattern of zeros for most of the writes,
>> so that the allocation test didn't really work out. This is fixed by using an
>> explicit pattern.
>>
>> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
>> ---
>> v2:
>> - Include changes to 019.out to contain the expected output for the new script.
>>   The test still fails on git master, but that's a real qemu-img bug.
> 
> I'd rather wait adding more testing until it actually works.  The
> alternative would be to move the test for the new option into a separate
> test case.

It's going to get forgotten this way, but it's your decision. Certainly
at some point I'll notice that I have a local patch that isn't applied
yet and I can resend it then.

Kevin