From: Gerd Hoffmann <kraxel@redhat.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Kevin Wolf <kwolf@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
seabios@seabios.org, QEMU Developers <qemu-devel@nongnu.org>,
Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/2] pci: Automatically patch PCI device id in PCI ROM
Date: Mon, 18 Oct 2010 12:09:23 +0200 [thread overview]
Message-ID: <4CBC1CD3.1040904@redhat.com> (raw)
In-Reply-To: <4CB8C20A.70706@codemonkey.ws>
On 10/15/10 23:05, Anthony Liguori wrote:
> On 10/15/2010 03:51 PM, Stefan Weil wrote:
>> PCI device with different device ids sometimes share
>> the same rom code. Only the device id and the checksum
>> differ in a boot rom for such devices.
>
> BTW, SeaBIOS doesn't reject ROMs when they're loaded via rombar, only
> when they're loaded via romfile.
SeaBIOS rejects them when loaded from the rom bar and doesn't reject
them when loaded via fw_cfg.
Using the rom bar is the prefered way though, fw_cfg is only there for
compatibility with older versions.
> Maybe it's better to use fw_cfg to explicitly tell SeaBIOS to ignore the
> PCI device id in the rom header for a certain device?
Patching the rom is fine IMHO. Why create + use a separate
communication path when we can use a much simpler approach?
cheers,
Gerd
next prev parent reply other threads:[~2010-10-18 10:09 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-12 12:41 [Qemu-devel] Where's gpxe-eepro100-80862449.rom ? Markus Armbruster
2010-10-12 16:18 ` [Qemu-devel] " Stefan Weil
2010-10-13 7:13 ` Markus Armbruster
2010-10-15 20:51 ` [Qemu-devel] [PATCH 1/2] pci: Automatically patch PCI device id in PCI ROM Stefan Weil
2010-10-15 21:05 ` Anthony Liguori
2010-10-18 10:09 ` Gerd Hoffmann [this message]
2010-10-18 18:39 ` Anthony Liguori
2010-10-21 10:09 ` [SeaBIOS] " Avi Kivity
2010-10-21 13:14 ` Anthony Liguori
2010-10-21 15:34 ` Avi Kivity
2010-10-18 10:04 ` Gerd Hoffmann
2010-10-18 11:16 ` Stefan Weil
2010-10-18 11:54 ` Gerd Hoffmann
2010-10-18 13:16 ` Stefan Weil
2010-10-18 13:30 ` Gerd Hoffmann
2010-10-18 15:50 ` Gerd Hoffmann
2010-10-18 17:54 ` Stefan Weil
2010-10-18 17:55 ` [Qemu-devel] [PATCH 1/2] pci: Automatically patch PCI vendor id and " Stefan Weil
2010-10-18 17:58 ` [Qemu-devel] " Michael S. Tsirkin
2010-10-18 18:42 ` Anthony Liguori
2010-10-18 19:03 ` Michael S. Tsirkin
2010-10-18 19:36 ` Stefan Weil
2010-10-18 19:59 ` Anthony Liguori
2010-10-19 6:40 ` Gerd Hoffmann
2010-10-18 19:56 ` Anthony Liguori
2010-10-18 18:44 ` [Qemu-devel] " Anthony Liguori
2010-10-18 18:53 ` Anthony Liguori
2010-10-18 19:11 ` Stefan Weil
2010-10-19 8:37 ` Michael S. Tsirkin
2010-10-19 21:15 ` Stefan Weil
2010-10-19 21:22 ` Anthony Liguori
2010-10-19 21:25 ` Michael S. Tsirkin
2010-10-19 21:08 ` Stefan Weil
2010-10-20 7:19 ` [Qemu-devel] " Gerd Hoffmann
2010-10-20 20:30 ` Stefan Weil
2010-11-22 6:29 ` Michael S. Tsirkin
2010-10-15 20:51 ` [Qemu-devel] [PATCH 2/2] eepro100: Use a single rom file for all i825xx devices Stefan Weil
2010-11-22 6:29 ` [Qemu-devel] " Michael S. Tsirkin
2010-10-15 21:03 ` [Qemu-devel] Re: Where's gpxe-eepro100-80862449.rom ? Stefan Weil
2010-10-25 12:11 ` Markus Armbruster
2010-10-25 16:23 ` Stefan Weil
2010-10-25 16:54 ` Michael S. Tsirkin
2010-11-15 17:06 ` Stefan Weil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CBC1CD3.1040904@redhat.com \
--to=kraxel@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=seabios@seabios.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.