Re: [PATCH 06/12] regulator: add driver for tps6524x regulator

[Cyril Chemparathy <cyril-l0cyMroinI0@public.gmane.org>]

Hi Mark,

Thanks for the feedback.  I agree with your comments, and I will make
the necessary changes before posting a v2.

The one exception being...

[...]
>> +static const int dcdc1_voltages[] = {
>> +	 800000,  825000,  850000,  875000,
>> +	 900000,  925000,  950000,  975000,
>> +	1000000, 1025000, 1050000, 1075000,
>> +	1100000, 1125000, 1150000, 1175000,
>> +	1200000, 1225000, 1250000, 1275000,
>> +	1300000, 1325000, 1350000, 1375000,
>> +	1400000, 1425000, 1450000, 1475000,
>> +	1500000, 1525000, 1550000, 1575000,
> 
> Looks like you could just do the maths for most of these tables, might
> be a bit clearer/simpler?  Not a major issue either way, though.

... not all of the supplies are linear (e.g. ldo2).  Rather than have to
deal with both cases (linear and non-linear), enumerating the list of
voltages appeared to be simpler.

[...]

Regards
Cyril.

------------------------------------------------------------------------------
Download new Adobe(R) Flash(R) Builder(TM) 4
The new Adobe(R) Flex(R) 4 and Flash(R) Builder(TM) 4 (formerly 
Flex(R) Builder(TM)) enable the development of rich applications that run
across multiple browsers and platforms. Download your free trials today!
http://p.sf.net/sfu/adobe-dev2dev