From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=42856 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1P7rzH-0005ob-1u
	for qemu-devel@nongnu.org; Mon, 18 Oct 2010 11:51:00 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1P7rzF-0001Ek-UZ
	for qemu-devel@nongnu.org; Mon, 18 Oct 2010 11:50:58 -0400
Received: from mx1.redhat.com ([209.132.183.28]:36556)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1P7rzF-0001EW-OF
	for qemu-devel@nongnu.org; Mon, 18 Oct 2010 11:50:57 -0400
Message-ID: <4CBC6CDB.109@redhat.com>
Date: Mon, 18 Oct 2010 17:50:51 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 1/2] pci: Automatically patch PCI device
	id in	PCI ROM
References: <m3bp6y5zvu.fsf@blackfin.pond.sub.org>	<1287175867-7757-1-git-send-email-weil@mail.berlios.de>	<4CBC1BA8.7030604@redhat.com>
	<4CBC2C7A.4000803@mail.berlios.de> <4CBC3572.6000908@redhat.com>
	<4CBC48A0.3030701@mail.berlios.de> <4CBC4C0F.3060204@redhat.com>
In-Reply-To: <4CBC4C0F.3060204@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <weil@mail.berlios.de>
Cc: Markus Armbruster <armbru@redhat.com>, QEMU Developers <qemu-devel@nongnu.org>, "Michael S. Tsirkin" <mst@redhat.com>

On 10/18/10 15:30, Gerd Hoffmann wrote:
>   Hi,
>
>>> When following this argumentation the vendor id sanity check shouldn't
>>> be there in the first place ;)
>>
>> The sanity check is simply there because I had no test case
>> which patches the vendor id. How could I test with vga bios?
>
> No trivial way as the vgabios needs to be patched to handle that.

patchrom branches available now:

http://cgit.freedesktop.org/~kraxel/vgabios/log/
http://cgit.freedesktop.org/spice/qemu/log/?h=patchrom

very short instructions:

(1) fetch+compile vgabios, copy new vgabios-pci binary
     so qemu can find it.
(2) fetch qemu, apply/merge id patching, compile qemu
(3) both standard and vmware vga should happily work
     with the same vgabios binary now, including vesa
     graphic modes.

cheers,
   Gerd