From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boaz Harrosh Subject: [PATCH] exofs: Set i_mapping->backing_dev_info anyway Date: Mon, 18 Oct 2010 20:34:20 +0200 Message-ID: <4CBC932C.1050405@panasas.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit To: Christoph Hellwig , linux-fsdevel Return-path: Received: from exprod5og104.obsmtp.com ([64.18.0.178]:33506 "HELO exprod5og104.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1755239Ab0JRSe1 (ORCPT ); Mon, 18 Oct 2010 14:34:27 -0400 Sender: linux-fsdevel-owner@vger.kernel.org List-ID: I've pushed below patch to the exofs/linux-next tree. I know it is just pointless right now. But for documentation sake and future ease of changes. --- From: Boaz Harrosh Subject: [PATCH] exofs: Set i_mapping->backing_dev_info anyway Though it has been promised that inode->i_mapping->backing_dev_info is not used and the supporting code is fine. Until the pointer will default to NULL, I'd rather it points to the correct thing regardless. At least for future infrastructure coder it is a clear indication of where are the key points that inodes are initialized. I know because it took me time to find this out. Signed-off-by: Boaz Harrosh --- fs/exofs/inode.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/fs/exofs/inode.c b/fs/exofs/inode.c index 24ab327..0ba9886 100644 --- a/fs/exofs/inode.c +++ b/fs/exofs/inode.c @@ -1030,6 +1030,7 @@ struct inode *exofs_iget(struct super_block *sb, unsigned long ino) memcpy(oi->i_data, fcb.i_data, sizeof(fcb.i_data)); } + inode->i_mapping->backing_dev_info = sb->s_bdi; if (S_ISREG(inode->i_mode)) { inode->i_op = &exofs_file_inode_operations; inode->i_fop = &exofs_file_operations; @@ -1129,6 +1130,7 @@ struct inode *exofs_new_inode(struct inode *dir, int mode) sbi = sb->s_fs_info; + inode->i_mapping->backing_dev_info = sb->s_bdi; sb->s_dirt = 1; inode_init_owner(inode, dir, mode); inode->i_ino = sbi->s_nextid++; -- 1.7.2.3