From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=45559 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P7upy-0001Ou-34 for qemu-devel@nongnu.org; Mon, 18 Oct 2010 14:53:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1P7upw-0005Pr-U9 for qemu-devel@nongnu.org; Mon, 18 Oct 2010 14:53:33 -0400 Received: from fmmailgate01.web.de ([217.72.192.221]:50962) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1P7upw-0005Oy-Ik for qemu-devel@nongnu.org; Mon, 18 Oct 2010 14:53:32 -0400 Message-ID: <4CBC97A5.6090602@web.de> Date: Mon, 18 Oct 2010 20:53:25 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <20101004211558.GB27035@udp111988uds.am.freescale.net> <20101018183227.GA15341@udp111988uds.am.freescale.net> In-Reply-To: <20101018183227.GA15341@udp111988uds.am.freescale.net> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigE4A74B9A3EE487574C5C2C6E" Sender: jan.kiszka@web.de Subject: [Qemu-devel] Re: [PATCH] Don't call cpu_synchronize_state() from machine init. List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Scott Wood Cc: QEMU Developers This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigE4A74B9A3EE487574C5C2C6E Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Am 18.10.2010 20:32, Scott Wood wrote: > On Mon, Oct 04, 2010 at 04:15:58PM -0500, Scott Wood wrote: >> This will deadlock when the I/O thread is used, since the >> CPU thread is blocked waiting for qemu_system_ready. >> >> The synchronization is unnecessary since this is before >> cpu_synchronize_all_post_init(). >> >> Signed-off-by: Scott Wood >> --- >> hw/ppc440_bamboo.c | 2 -- >> hw/ppce500_mpc8544ds.c | 2 -- >> 2 files changed, 0 insertions(+), 4 deletions(-) >=20 > Any comment on/objection to this patch? >=20 Obviously correct, should get committed. Acked-by: Jan Kiszka Jan > -Scott >=20 >> >> diff --git a/hw/ppc440_bamboo.c b/hw/ppc440_bamboo.c >> index 34ddf45..645e84f 100644 >> --- a/hw/ppc440_bamboo.c >> +++ b/hw/ppc440_bamboo.c >> @@ -156,8 +156,6 @@ static void bamboo_init(ram_addr_t ram_size, >> exit(1); >> } >> =20 >> - cpu_synchronize_state(env); >> - >> /* Set initial guest state. */ >> env->gpr[1] =3D (16<<20) - 8; >> env->gpr[3] =3D FDT_ADDR; >> diff --git a/hw/ppce500_mpc8544ds.c b/hw/ppce500_mpc8544ds.c >> index 1422fad..f7e9465 100644 >> --- a/hw/ppce500_mpc8544ds.c >> +++ b/hw/ppce500_mpc8544ds.c >> @@ -269,8 +269,6 @@ static void mpc8544ds_init(ram_addr_t ram_size, >> exit(1); >> } >> =20 >> - cpu_synchronize_state(env); >> - >> /* Set initial guest state. */ >> env->gpr[1] =3D (16<<20) - 8; >> env->gpr[3] =3D dt_base; >> --=20 >> 1.7.0.4 >> >> >=20 >=20 >=20 --------------enigE4A74B9A3EE487574C5C2C6E Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.15 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org/ iEYEARECAAYFAky8l6kACgkQitSsb3rl5xTeVACgh8ThEM5YNR2htVzLYYD8nuoz AtIAoJ9RTDCNHCZpVMctCsoLm3UnKmiP =5WSe -----END PGP SIGNATURE----- --------------enigE4A74B9A3EE487574C5C2C6E--