From: ryan@bluewatersys.com (Ryan Mallon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] EP93xx: Document DMA M2P API
Date: Tue, 19 Oct 2010 08:36:22 +1300 [thread overview]
Message-ID: <4CBCA1B6.1040303@bluewatersys.com> (raw)
In-Reply-To: <20101018074335.GD4772@gw.healthdatacare.com>
On 10/18/2010 08:43 PM, Mika Westerberg wrote:
> On Mon, Oct 18, 2010 at 01:50:29PM +1300, Ryan Mallon wrote:
>> Add documentation for the EP93xx DMA memory to peripheral/peripheral to
>> memory API.
>
> This is a good thing but I think that you might want to use standard
> kernel-doc style comments (see Documentation/kernel-doc-nano-HOWTO.txt)
> so that we can get nicely formatted document of the DMA API when
> 'make *docs' is run.
Ah, thanks. I didn't know there was documentation for kernel-doc :-). I
had just been copying the way other subsystems were done. Will fix up
and repost.
>
> /**
> * ep93xx_dma_m2p_client_register - register a client ..
>
>
> Also you might want to put these function comments in the .c file (so they
> are as close the actual code as possible).
I prefer the comments in the header, since if the API documentation is
good the user will never have to look at the C code.
~Ryan
--
Bluewater Systems Ltd - ARM Technology Solution Centre
Ryan Mallon 5 Amuri Park, 404 Barbadoes St
ryan at bluewatersys.com PO Box 13 889, Christchurch 8013
http://www.bluewatersys.com New Zealand
Phone: +64 3 3779127 Freecall: Australia 1800 148 751
Fax: +64 3 3779135 USA 1800 261 2934
next prev parent reply other threads:[~2010-10-18 19:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-18 0:50 [PATCH] EP93xx: Document DMA M2P API Ryan Mallon
2010-10-18 7:43 ` Mika Westerberg
2010-10-18 19:36 ` Ryan Mallon [this message]
2010-10-19 19:52 ` Ryan Mallon
2010-10-19 20:05 ` Mika Westerberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CBCA1B6.1040303@bluewatersys.com \
--to=ryan@bluewatersys.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.