All of lore.kernel.org
 help / color / mirror / Atom feed
From: Magnus Lilja <lilja.magnus@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] i.MX31: Fix Litekit board to use new ARM	relocation support.
Date: Mon, 18 Oct 2010 21:50:33 +0200	[thread overview]
Message-ID: <4CBCA509.9000901@gmail.com> (raw)
In-Reply-To: <4CBC05BA.70505@denx.de>

Hi Stefano,

On 2010-10-18 10:30, Stefano Babic wrote:
> On 10/16/2010 07:47 PM, Magnus Lilja wrote:
>> Tested on hardware. Boots Linux nicely.
>>
>> Signed-off-by: Magnus Lilja <lilja.magnus@gmail.com>
>> ---
> 
> Hi Magnus,
> 
>> @@ -31,12 +31,18 @@ DECLARE_GLOBAL_DATA_PTR;
>>  
>>  int dram_init (void)
>>  {
>> -	gd->bd->bi_dram[0].start = PHYS_SDRAM_1;
>> -	gd->bd->bi_dram[0].size = PHYS_SDRAM_1_SIZE;
>> +	gd->ram_size = PHYS_SDRAM_1_SIZE;
> 
> Any reason to not use get_ram_size() ?

Yes, lowlevel_init.S for the litekit board doesn't support autodetection of ram size. I suppose the SDRAM controller needs to be reprogrammed with the actual ool/row settings depending on the RAM size. 

Also, I prefer making one change in each patch so this patch updates the Litekit board to use the new relocation stuff.

Regards, Magnus

  reply	other threads:[~2010-10-18 19:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-16 17:47 [U-Boot] [PATCH] i.MX31: Fix Litekit board to use new ARM relocation support Magnus Lilja
2010-10-18  8:30 ` Stefano Babic
2010-10-18 19:50   ` Magnus Lilja [this message]
2010-10-19 10:36 ` Stefano Babic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CBCA509.9000901@gmail.com \
    --to=lilja.magnus@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.