All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Smith <msmith@cbnco.com>
To: Frans Meulenbroeks <fransmeulenbroeks@gmail.com>
Cc: openembedded-devel <openembedded-devel@lists.openembedded.org>
Subject: Re: [PATCH v3] package.bbclass: copy dotfiles in root D to PKGD
Date: Mon, 18 Oct 2010 16:43:04 -0400	[thread overview]
Message-ID: <4CBCB158.2050500@cbnco.com> (raw)
In-Reply-To: <AANLkTi=DtXf+VnB3LPzbzDD57LNSxgUaeeTM6=ohGstK@mail.gmail.com>

Frans Meulenbroeks wrote:
> Signed-off-by: Frans Meulenbroeks <fransmeulenbroeks@gmail.com>
> 
> but with a minor improvement suggestion.
> What aboout elimiating one os.system call by combining the two into one:
> 
> os.system('rm -rf %s/*;cp -pPR %s/. %s/' % (pkgcopy, installdest, pkgcopy))

Hi Frans,

Thanks for the SOB. I like it better as two separate lines. I would have 
preferred shutil.rmtree() if shutil.copytree() worked, actually - but 
since it doesn't, no point using shutil for one line and not the other.

Mike



  parent reply	other threads:[~2010-10-18 20:43 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-18 16:44 [PATCH v3] package.bbclass: copy dotfiles in root D to PKGD Michael Smith
2010-10-18 17:33 ` Khem Raj
2010-10-18 18:00   ` Frans Meulenbroeks
2010-10-18 18:27 ` Khem Raj
     [not found] ` <AANLkTi=DtXf+VnB3LPzbzDD57LNSxgUaeeTM6=ohGstK@mail.gmail.com>
2010-10-18 20:43   ` Michael Smith [this message]
2010-10-19 13:16 ` Enrico Scholz
2010-10-19 13:25   ` Frans Meulenbroeks
2010-10-19 13:44     ` Henning Heinold
2010-10-19 17:07     ` Enrico Scholz
2010-10-19 17:24       ` Frans Meulenbroeks

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CBCB158.2050500@cbnco.com \
    --to=msmith@cbnco.com \
    --cc=fransmeulenbroeks@gmail.com \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.