All of lore.kernel.org
 help / color / mirror / Atom feed
From: Oliver Hartkopp <socketcan-fJ+pQTUTwRTk1uMJSBkQmQ@public.gmane.org>
To: Kurt Van Dijck <kurt.van.dijck-/BeEPy95v10@public.gmane.org>
Cc: socketcan-core-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org,
	netdev <netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Wolfgang Grandegger <wg-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
Subject: Re: [PATCH V3 net-next] can-raw: add msg_flags to distinguish local traffic
Date: Tue, 19 Oct 2010 13:33:19 +0200	[thread overview]
Message-ID: <4CBD81FF.5070004@hartkopp.net> (raw)
In-Reply-To: <4CBD7DF8.4040204-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>

On 19.10.2010 13:16, Wolfgang Grandegger wrote:
> On 10/19/2010 12:28 PM, Alexander Stein wrote:
>> On Tuesday 19 October 2010, 11:57:03 Kurt Van Dijck wrote:
>>> On Tue, Oct 19, 2010 at 11:12:56AM +0200, Alexander Stein wrote:
>>>> You mixed tabs and spaces at MSG_CONFIRM entry. Dunno if that was
>>>> intended.
>>>
>>> That was not intended.
>>> Is that a problem (I never studied the code style wrt. Documentation)?
>>
>> Dunno if this is a problem, I just stumbled over it.
> 
> Well, I think it's not worth an extra patch but should be fixed when the
> files need to be touched anyway (for other reasons/fixes).

But there's also no need to commit a broken indention.

>From my side i would prefer a V4 and you can put in my

Acked-by: Oliver Hartkopp <socketcan-fJ+pQTUTwRTk1uMJSBkQmQ@public.gmane.org>

directly if you like.

Thanks,
Oliver

      parent reply	other threads:[~2010-10-19 11:33 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-19  9:02 [PATCH V3 net-next] can-raw: add msg_flags to distinguish local traffic Kurt Van Dijck
     [not found] ` <20101019090247.GB334-MxZ6Iy/zr/UdbCeoMzGj59i2O/JbrIOy@public.gmane.org>
2010-10-19  9:12   ` Alexander Stein
     [not found]     ` <201010191113.46999.alexander.stein-93q1YBGzJSMe9JSWTWOYM3xStJ4P+DSV@public.gmane.org>
2010-10-19  9:57       ` Kurt Van Dijck
     [not found]         ` <20101019095703.GA436-MxZ6Iy/zr/UdbCeoMzGj59i2O/JbrIOy@public.gmane.org>
2010-10-19 10:28           ` Alexander Stein
     [not found]             ` <201010191228.10914.alexander.stein-93q1YBGzJSMe9JSWTWOYM3xStJ4P+DSV@public.gmane.org>
2010-10-19 11:16               ` Wolfgang Grandegger
     [not found]                 ` <4CBD7DF8.4040204-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
2010-10-19 11:33                   ` Oliver Hartkopp [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CBD81FF.5070004@hartkopp.net \
    --to=socketcan-fj+pqtutwrtk1umjsbkqmq@public.gmane.org \
    --cc=kurt.van.dijck-/BeEPy95v10@public.gmane.org \
    --cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=socketcan-core-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org \
    --cc=wg-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.