All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vladislav Bogdanov <bubble-Awb4OmSD/41iLUuM0BA3LQ@public.gmane.org>
To: Harald Hoyer <harald-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: One more fix (was Re: [RFC] [PATCH] Bonding support for dracut)
Date: Tue, 19 Oct 2010 17:49:09 +0300	[thread overview]
Message-ID: <4CBDAFE5.3020102@hoster-ok.com> (raw)
In-Reply-To: <4CBDA315.2070603-Awb4OmSD/41iLUuM0BA3LQ@public.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 61 bytes --]

Hi,

one more patch with fixes is attached.

Best,
Vladislav

[-- Attachment #2: dracut-bonding-support-fixes.patch --]
[-- Type: text/x-patch, Size: 2845 bytes --]

diff --git a/modules.d/45ifcfg/write-ifcfg.sh b/modules.d/45ifcfg/write-ifcfg.sh
index 45fcde2..022467b 100755
--- a/modules.d/45ifcfg/write-ifcfg.sh
+++ b/modules.d/45ifcfg/write-ifcfg.sh
@@ -68,12 +68,13 @@ for netif in $IFACES ; do
         } >> /tmp/ifcfg/ifcfg-$netif
 
         for slave in $bondslaves ; do
+            # Set ONBOOT=no to prevent initscripts from trying to setup already bonded physical interface
             # write separate ifcfg file for the raw eth interface
             {
                 echo "# Generated by dracut initrd"
                 echo "DEVICE=$slave"
                 echo "TYPE=Ethernet"
-                echo "ONBOOT=yes"
+                echo "ONBOOT=no"
                 echo "NETBOOT=yes"
                 echo "HWADDR=$(cat /sys/class/net/$slave/address)"
                 echo "SLAVE=yes"
@@ -91,23 +92,24 @@ for netif in $IFACES ; do
         } >> /tmp/ifcfg/ifcfg-$netif
         if [ "$ethname" = "$bondname" ] ; then
             {
-                # This variable is an indicator of a bond interface for initscripts
+                # Set ONBOOT=no to prevent initscripts from trying to setup already bridged bond interface
                 echo "# Generated by dracut initrd"
                 echo "DEVICE=$bondname"
-                echo "ONBOOT=yes"
+                echo "ONBOOT=no"
                 echo "NETBOOT=yes"
+                # This variable is an indicator of a bond interface for initscripts
                 echo "BONDING_OPTS=\"$bondoptions\""
                 echo "BRIDGE=$netif"
                 echo "NAME=\"$bondname\"" 
             } >> /tmp/ifcfg/ifcfg-$bondname
             for slave in $bondslaves ; do
                 # write separate ifcfg file for the raw eth interface
-                # yes, duplicated code at this moment
+                # Set ONBOOT=no to prevent initscripts from trying to setup already bridged physical interface
                 {
                     echo "# Generated by dracut initrd"
                     echo "DEVICE=$slave"
                     echo "TYPE=Ethernet"
-                    echo "ONBOOT=yes"
+                    echo "ONBOOT=no"
                     echo "NETBOOT=yes"
                     echo "HWADDR=$(cat /sys/class/net/$slave/address)"
                     echo "SLAVE=yes"
@@ -121,11 +123,11 @@ for netif in $IFACES ; do
                 echo "# Generated by dracut initrd"
                 echo "DEVICE=$ethname"
                 echo "TYPE=Ethernet"
-                echo "ONBOOT=yes"
+                echo "ONBOOT=no"
                 echo "NETBOOT=yes"
                 echo "HWADDR=$(cat /sys/class/net/$ethname/address)"
                 echo "BRIDGE=$netif"
-                echo "NAME=$ethname" 
+                echo "NAME=$ethname"
             } >> /tmp/ifcfg/ifcfg-$ethname
         fi
     fi

  parent reply	other threads:[~2010-10-19 14:49 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-18 12:04 [RFC] [PATCH] Bonding support for dracut Vladislav Bogdanov
     [not found] ` <4CBC37E7.9010904-Awb4OmSD/41iLUuM0BA3LQ@public.gmane.org>
2010-10-18 13:06   ` Harald Hoyer
     [not found]     ` <4CBC4661.3020100-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2010-10-18 13:48       ` Vladislav Bogdanov
     [not found]         ` <4CBC504A.7020002-Awb4OmSD/41iLUuM0BA3LQ@public.gmane.org>
2010-10-18 13:59           ` Harald Hoyer
2010-10-18 14:15           ` Harald Hoyer
     [not found]             ` <4CBC566C.9080407-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2010-10-18 14:31               ` Vladislav Bogdanov
     [not found]                 ` <4CBC5A48.1010304-Awb4OmSD/41iLUuM0BA3LQ@public.gmane.org>
2010-10-18 14:41                   ` Harald Hoyer
     [not found]                     ` <4CBC5C7C.4000504-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2010-10-19 13:54                       ` Vladislav Bogdanov
     [not found]                         ` <4CBDA315.2070603-Awb4OmSD/41iLUuM0BA3LQ@public.gmane.org>
2010-10-19 14:49                           ` Vladislav Bogdanov [this message]
     [not found]                             ` <4CBDAFE5.3020102-Awb4OmSD/41iLUuM0BA3LQ@public.gmane.org>
2010-10-28 15:14                               ` One more fix (was Re: [RFC] [PATCH] Bonding support for dracut) Harald Hoyer
2010-10-28 15:13                           ` [RFC] [PATCH] Bonding support for dracut Harald Hoyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CBDAFE5.3020102@hoster-ok.com \
    --to=bubble-awb4omsd/41iluum0ba3lq@public.gmane.org \
    --cc=harald-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.