From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=60542 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1P8JXN-0004NQ-Pr
	for qemu-devel@nongnu.org; Tue, 19 Oct 2010 17:16:02 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <weil@mail.berlios.de>) id 1P8JXM-0002vc-N7
	for qemu-devel@nongnu.org; Tue, 19 Oct 2010 17:16:01 -0400
Received: from moutng.kundenserver.de ([212.227.126.171]:59365)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <weil@mail.berlios.de>) id 1P8JXM-0002u6-CZ
	for qemu-devel@nongnu.org; Tue, 19 Oct 2010 17:16:00 -0400
Message-ID: <4CBE0A7A.5030500@mail.berlios.de>
Date: Tue, 19 Oct 2010 23:15:38 +0200
From: Stefan Weil <weil@mail.berlios.de>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 1/2] pci: Automatically patch PCI vendor
	id and device id in PCI ROM
References: <4CBC6CDB.109@redhat.com>
	<1287424511-22021-1-git-send-email-weil@mail.berlios.de>
	<4CBC957D.3040007@codemonkey.ws> <4CBC97BE.7070902@codemonkey.ws>
	<4CBC9BFB.9090504@mail.berlios.de>
	<20101019083740.GA4465@redhat.com>
In-Reply-To: <20101019083740.GA4465@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>, Markus Armbruster <armbru@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>

Am 19.10.2010 10:37, schrieb Michael S. Tsirkin:
> On Mon, Oct 18, 2010 at 09:11:55PM +0200, Stefan Weil wrote:
>> QEMU must only make sure that patching of the supported roms
>> with supported devices work.
>
> I think that's what Anthony was saying too - make this depend
> on a qdev property and set it only in eepro100 for now.
>

My new patch v3 implements something similar and does not need
a new qdev property:

Don't patch because the rom file was defined by the user:

qemu -L pc-bios -boot n -netdev user,id=internet \
     -device i82801,netdev=internet,romfile=gpxe-eepro100-80861209.rom

Patch because we work with the built-in default rom file:

qemu -L pc-bios -boot n -netdev user,id=internet \
     -device i82801,netdev=internet

This is a safe solution which respects user's rom data
without adding much more complexity.

Regards,
Stefan