From: Cong Wang <amwang@redhat.com>
To: nhorman@tuxdriver.com
Cc: netdev@vger.kernel.org, bonding-devel@lists.sourceforge.net,
fubar@us.ibm.com, davem@davemloft.net, andy@greyhouse.net
Subject: Re: [PATCH 2/2] Revert napi_poll fix for bonding driver
Date: Wed, 20 Oct 2010 15:52:00 +0800 [thread overview]
Message-ID: <4CBE9FA0.6010900@redhat.com> (raw)
In-Reply-To: <1287507866-25156-3-git-send-email-nhorman@tuxdriver.com>
On 10/20/10 01:04, nhorman@tuxdriver.com wrote:
> From: Neil Horman<nhorman@tuxdriver.com>
>
> In an erlier patch I modified napi_poll so that devices with IFF_MASTER polled
> the per_cpu list instead of the device list for napi. I did this because the
> bonding driver has no napi instances to poll, it instead expects to check the
> slave devices napi instances, which napi_poll was unaware of. Looking at this
> more closely however, I now see this isn't strictly needed. As the bond driver
> poll_controller calls the slaves poll_controller via netpoll_poll_dev, which
> recursively calls poll_napi on each slave, allowing those napi instances to get
> serviced. The earlier patch isn't at all harmfull, its just not needed, so lets
> revert it to make the code cleaner. Sorry for the noise,
>
> Signed-off-by: Neil Horman<nhorman@tuxdriver.com>
Looks reasonable to me,
Reviewed-by: WANG Cong <amwang@redhat.com>
Thanks.
next prev parent reply other threads:[~2010-10-20 7:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-19 17:04 [PATCH] bonding: minor cleanups to bond + netpoll nhorman
2010-10-19 17:04 ` [PATCH 1/2] Remove netpoll blocking from uninit path nhorman
2010-10-20 7:47 ` Cong Wang
2010-10-20 8:45 ` David Miller
2010-10-20 10:51 ` Neil Horman
2010-10-19 17:04 ` [PATCH 2/2] Revert napi_poll fix for bonding driver nhorman
2010-10-20 7:52 ` Cong Wang [this message]
2010-10-20 8:45 ` David Miller
2010-10-19 20:29 ` [PATCH] bonding: minor cleanups to bond + netpoll Andy Gospodarek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CBE9FA0.6010900@redhat.com \
--to=amwang@redhat.com \
--cc=andy@greyhouse.net \
--cc=bonding-devel@lists.sourceforge.net \
--cc=davem@davemloft.net \
--cc=fubar@us.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.