All of lore.kernel.org
 help / color / mirror / Atom feed
From: Suraj Sumangala <suraj@Atheros.com>
To: Waldemar Rymarkiewicz <waldemar.rymarkiewicz@tieto.com>
Cc: "linux-bluetooth@vger.kernel.org"
	<linux-bluetooth@vger.kernel.org>,
	Marcel Holtmann <marcel@holtmann.org>,
	Suraj Sumangala <Suraj.Sumangala@Atheros.com>,
	Johan Hedberg <johan.hedberg@gmail.com>,
	"joakim.xj.ceder@stericsson.com" <joakim.xj.ceder@stericsson.com>,
	"arunkr.singh@stericsson.com" <arunkr.singh@stericsson.com>
Subject: Re: [PATCH 1/1] Add Sim Access Plugin
Date: Wed, 20 Oct 2010 14:07:25 +0530	[thread overview]
Message-ID: <4CBEAA45.4010702@Atheros.com> (raw)
In-Reply-To: <1287561308-18611-2-git-send-email-waldemar.rymarkiewicz@tieto.com>

Hi Waldemar,

On 10/20/2010 1:25 PM, Waldemar Rymarkiewicz wrote:
> Sim Access plugin implements Sim Access Profile server role
> according to the Bluetooth Sim Access Profile v1.1 specification.
> ---
>   .gitignore      |    1 +
>   Makefile.am     |   25 +-
>   acinclude.m4    |   14 +
>   doc/sap-api.txt |   57 ++
>   sap/main.c      |   54 ++
>   sap/manager.c   |   94 ++++
>   sap/manager.h   |   21 +
>   sap/sap-dummy.c |  306 +++++++++++
>   sap/sap-ste.c   | 1265 ++++++++++++++++++++++++++++++++++++++++++++++
>   sap/sap.h       |  187 +++++++
>   sap/server.c    | 1516 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
>   sap/server.h    |   23 +
>   12 files changed, 3559 insertions(+), 4 deletions(-)
>   create mode 100644 doc/sap-api.txt
>   create mode 100644 sap/main.c
>   create mode 100644 sap/manager.c
>   create mode 100644 sap/manager.h
>   create mode 100644 sap/sap-dummy.c
>   create mode 100644 sap/sap-ste.c
I am assuming that this is the ST specific plugin. May be you can just 
keep the dummy plugin only so that someone can use that as a reference.
>   create mode 100644 sap/sap.h
>   create mode 100644 sap/server.c
>   create mode 100644 sap/server.h

I guess it would be better if you can split this into multiple patches 
so that it would be easier to review.

Regards
Suraj

  reply	other threads:[~2010-10-20  8:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-20  7:55 [PATCH 0/1] Add Sim Access plugin Waldemar Rymarkiewicz
2010-10-20  7:55 ` [PATCH 1/1] Add Sim Access Plugin Waldemar Rymarkiewicz
2010-10-20  8:37   ` Suraj Sumangala [this message]
2010-10-20  8:47     ` Waldemar.Rymarkiewicz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CBEAA45.4010702@Atheros.com \
    --to=suraj@atheros.com \
    --cc=Suraj.Sumangala@Atheros.com \
    --cc=arunkr.singh@stericsson.com \
    --cc=joakim.xj.ceder@stericsson.com \
    --cc=johan.hedberg@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=marcel@holtmann.org \
    --cc=waldemar.rymarkiewicz@tieto.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.