All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zdenek Kabelac <zkabelac@redhat.com>
To: lvm-devel@redhat.com
Subject: [PATCH 4/4] Update tests for lvseg apis.
Date: Wed, 20 Oct 2010 14:08:46 +0200	[thread overview]
Message-ID: <4CBEDBCE.1060400@redhat.com> (raw)
In-Reply-To: <1287494696-18310-5-git-send-email-dwysocha@redhat.com>

Dne 19.10.2010 15:24, Dave Wysochanski napsal(a):
> 
> Signed-off-by: Dave Wysochanski <dwysocha@redhat.com>
> ---
>  test/api/test.c |   76 ++++++++++++++++++++++++++++--------------------------
>  1 files changed, 39 insertions(+), 37 deletions(-)
> 
> diff --git a/test/api/test.c b/test/api/test.c
> index fea3d0d..20f4210 100644
> --- a/test/api/test.c
> +++ b/test/api/test.c
> @@ -69,6 +69,8 @@ static void _show_help(void)
>  	       "List the PVs that exist in VG vgname\n");
>  	printf("'vg_list_lvs vgname': "
>  	       "List the LVs that exist in VG vgname\n");
> +	printf("'lv_list_lvsegs vgname lvname': "
> +	       "List the LV segments that exist in LV vgname/lvname\n");
>  	printf("'vgs_open': "
>  	       "List the VGs that are currently open\n");
>  	printf("'vgs': "
> @@ -569,12 +571,15 @@ static void _vg_tag(char **argv, int argc, int add)
>  	       add ? "adding":"removing", argv[2], argv[1]);
>  }
>  
> -static void _print_property_value(struct lvm_property_value value)
> +static void _print_property_value(const char *name,
> +				  struct lvm_property_value v)

const struct if you do not modify it.
And I think using pointer would be wise decision here.


>  
>  static void _pv_get_property(char **argv, int argc)
> @@ -589,17 +594,7 @@ static void _pv_get_property(char **argv, int argc)

const array of const pointers ?

Zdenek



  reply	other threads:[~2010-10-20 12:08 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-19 13:24 [PATCH 00/04] Add lvm lvseg properties for lvm2app Dave Wysochanski
2010-10-19 13:24 ` [PATCH 1/4] Add lvseg_t to lvm2app and lvm_lv_list_lvsegs() Dave Wysochanski
2010-10-19 13:24 ` [PATCH 2/4] Add lvseg 'get' functions Dave Wysochanski
2010-10-20 11:53   ` Zdenek Kabelac
2010-10-21 16:36     ` Petr Rockai
2010-10-19 13:24 ` [PATCH 3/4] Add lvm_lvseg_get_property() function Dave Wysochanski
2010-10-20 11:47   ` Zdenek Kabelac
2010-10-19 13:24 ` [PATCH 4/4] Update tests for lvseg apis Dave Wysochanski
2010-10-20 12:08   ` Zdenek Kabelac [this message]
2010-10-21 16:38     ` Petr Rockai
2010-10-22  8:26       ` Zdenek Kabelac
2010-10-22  8:59         ` Petr Rockai
2010-10-24 16:24           ` Zdenek Kabelac
2010-10-24 21:06             ` Petr Rockai
2010-10-25 13:27               ` Zdenek Kabelac

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CBEDBCE.1060400@redhat.com \
    --to=zkabelac@redhat.com \
    --cc=lvm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.