From: Avi Kivity <avi@redhat.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: mtosatti@redhat.com, kvm@vger.kernel.org,
Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH] KVM: Move KVM context switch into own function
Date: Wed, 20 Oct 2010 18:12:11 +0200 [thread overview]
Message-ID: <4CBF14DB.5020109@redhat.com> (raw)
In-Reply-To: <1287590177-25094-1-git-send-email-andi@firstfloor.org>
On 10/20/2010 05:56 PM, Andi Kleen wrote:
> From: Andi Kleen<ak@linux.intel.com>
>
> gcc 4.5 with some special options is able to duplicate the VMX
> context switch asm in vmx_vcpu_run(). This results in a compile error
> because the inline asm sequence uses an on local label. The non local
> label is needed because other code wants to set up the return address.
>
Curious, any idea why gcc does that? I guess it's the unlikely() near
the top.
Anyway, patch looks fine.
--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.
next prev parent reply other threads:[~2010-10-20 16:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-20 15:56 [PATCH] KVM: Move KVM context switch into own function Andi Kleen
2010-10-20 16:12 ` Avi Kivity [this message]
2010-10-20 16:20 ` Andi Kleen
2010-10-21 17:28 ` Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CBF14DB.5020109@redhat.com \
--to=avi@redhat.com \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.