From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steve Wise Subject: Re: [PATCH 2.6.37] RDMA/cxgb3: When a user QP is marked in error, also mark the CQs in error. Date: Wed, 20 Oct 2010 17:37:51 -0500 Message-ID: <4CBF6F3F.10507@opengridcomputing.com> References: <20101020214432.4869.50981.stgit@build.ogc.int> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: "Hefty, Sean" Cc: "rdreier-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org" , "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: linux-rdma@vger.kernel.org On 10/20/2010 05:10 PM, Hefty, Sean wrote: >> @@ -217,15 +218,24 @@ static struct ib_cq *iwch_create_cq(struct ib_device >> *ibdev, int entries, int ve >> uresp.key = ucontext->key; >> ucontext->key += PAGE_SIZE; >> spin_unlock(&ucontext->mmap_lock); >> + mm->key = uresp.key; >> + mm->addr = virt_to_phys(chp->cq.queue); >> + if (udata->outlen< sizeof uresp) { >> + if (!warned++) >> + printk(KERN_WARNING MOD "Warning - " >> + "downlevel libcxgb3 (non-fatal).\n"); >> + mm->len = PAGE_ALIGN((1UL<< uresp.size_log2) * >> + sizeof(struct t3_cqe)); >> + } else { >> + mm->len = PAGE_ALIGN(((1UL<< uresp.size_log2) + 1) * >> + sizeof(struct t3_cqe)); >> + uresp.memsize = mm->len; >> + } >> if (ib_copy_to_udata(udata,&uresp, sizeof (uresp))) { >> > Is this correct? udata->outlen can be less than sizeof uresp here. > > The only way it can be less is if the library is using the ABI 0 version of the response struct. Or am I missing something? Steve. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html