From: Anthony Liguori <anthony@codemonkey.ws>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Alon Levy <alevy@redhat.com>,
qemu-devel@nongnu.org, Luiz Capitulino <lcapitulino@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 0/3] add usb_detach and usb_attach (v3)
Date: Thu, 21 Oct 2010 08:13:19 -0500 [thread overview]
Message-ID: <4CC03C6F.4020304@codemonkey.ws> (raw)
In-Reply-To: <4CC03A2D.9030105@redhat.com>
On 10/21/2010 08:03 AM, Gerd Hoffmann wrote:
> On 10/21/10 08:36, Alon Levy wrote:
>> v2->v3 changes:
>> * add configure parameter
>> * fix docs
>>
>> v2 message:
>> This patchset uses id like device_del for attaching/detaching usb
>> devices. The first two patches ready the way:
>> 1. makes qdev_find_recursive non static and in qdev.h
>> 2. adds a usb_device_by_id which goes over the usb buses calling
>> qdev_find_recursive
>> 3. adds the commands that use usb_device_by_id
>>
>> Alon Levy (3):
>> qdev: make qdev_find_recursive public
>> usb: add public usb_device_by_id
>> monitor: add usb_attach and usb_detach (v2)
>>
>
> Acked-by: Gerd Hoffmann <kraxel@redhat.com>
Okay, I am still confused about the use-case for this and I don't see
any further explanation in the commit messages. I've seen "debugging"
but can you be a bit more specific about which cases it's needed for?
This is just adding a HMP command. Is that the right approach or was
that an unintentional consequence of rebasing post-HMP/QMP split?
Regards,
Anthony Liguori
>
> cheers,
> Gerd
>
>
next prev parent reply other threads:[~2010-10-21 13:13 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-21 6:36 [Qemu-devel] [PATCH 0/3] add usb_detach and usb_attach (v3) Alon Levy
2010-10-21 6:36 ` [Qemu-devel] [PATCH 1/3] qdev: make qdev_find_recursive public Alon Levy
2010-10-21 6:36 ` [Qemu-devel] [PATCH 2/3] usb: add public usb_device_by_id Alon Levy
2010-10-21 6:36 ` [Qemu-devel] [PATCH 3/3] monitor: add usb_attach and usb_detach (v2) Alon Levy
2010-10-21 13:03 ` [Qemu-devel] [PATCH 0/3] add usb_detach and usb_attach (v3) Gerd Hoffmann
2010-10-21 13:13 ` Anthony Liguori [this message]
2010-10-21 13:24 ` Alon Levy
2010-10-22 3:16 ` Ryan Harper
2010-11-10 15:49 ` Markus Armbruster
2010-11-10 20:41 ` Alon Levy
2010-11-11 10:29 ` Markus Armbruster
2010-11-11 12:56 ` Alon Levy
2010-11-11 15:03 ` Markus Armbruster
2010-11-11 17:01 ` Alon Levy
2010-10-21 13:27 ` Alon Levy
2010-10-22 12:48 ` Luiz Capitulino
2010-10-22 12:55 ` Anthony Liguori
2010-10-22 13:17 ` Luiz Capitulino
2010-10-22 13:43 ` Anthony Liguori
2010-10-22 13:45 ` Luiz Capitulino
2010-10-25 8:44 ` Alon Levy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CC03C6F.4020304@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=alevy@redhat.com \
--cc=kraxel@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.