From: Sergei Shtylyov <sshtylyov@mvista.com>
To: Mike Frysinger <vapier@gentoo.org>
Cc: linux-ide@vger.kernel.org, Jeff Garzik <jgarzik@pobox.com>,
uclinux-dist-devel@blackfin.uclinux.org
Subject: Re: [PATCH] pata_bf54x: fix return type of bfin_set_devctl
Date: Thu, 21 Oct 2010 21:45:10 +0400 [thread overview]
Message-ID: <4CC07C26.5090508@mvista.com> (raw)
In-Reply-To: <1287648040-19759-1-git-send-email-vapier@gentoo.org>
Hello.
On 21-10-2010 12:00, Mike Frysinger wrote:
> The new devctl func added for us to the driver has the wrong return
> type. Which is to say there shouldn't be any. This fixes compile
> time warnings as there shouldn't be any runtime difference.
> Signed-off-by: Mike Frysinger<vapier@gentoo.org>
[...]
> diff --git a/drivers/ata/pata_bf54x.c b/drivers/ata/pata_bf54x.c
> index 9cae65d..5eeb922 100644
> --- a/drivers/ata/pata_bf54x.c
> +++ b/drivers/ata/pata_bf54x.c
> @@ -826,7 +826,7 @@ static void bfin_dev_select(struct ata_port *ap, unsigned int device)
> * @ctl: value to write
> */
>
> -static u8 bfin_set_devctl(struct ata_port *ap, u8 ctl)
> +static void bfin_set_devctl(struct ata_port *ap, u8 ctl)
Sorry about that. Don't know how 'u8' crawled in...
MBR, Sergei
prev parent reply other threads:[~2010-10-21 19:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-21 8:00 [PATCH] pata_bf54x: fix return type of bfin_set_devctl Mike Frysinger
2010-10-21 17:45 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CC07C26.5090508@mvista.com \
--to=sshtylyov@mvista.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.