From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=38884 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1P9Ckc-0001z3-Lk
	for qemu-devel@nongnu.org; Fri, 22 Oct 2010 04:13:28 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Jes.Sorensen@redhat.com>) id 1P9CdR-0007MM-0I
	for qemu-devel@nongnu.org; Fri, 22 Oct 2010 04:05:58 -0400
Received: from mx1.redhat.com ([209.132.183.28]:52880)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Jes.Sorensen@redhat.com>) id 1P9CdQ-0007M5-Pj
	for qemu-devel@nongnu.org; Fri, 22 Oct 2010 04:05:56 -0400
Received: from int-mx08.intmail.prod.int.phx2.redhat.com
	(int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o9M85t89003722
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Fri, 22 Oct 2010 04:05:55 -0400
Message-ID: <4CC145E1.3000206@redhat.com>
Date: Fri, 22 Oct 2010 10:05:53 +0200
From: Jes Sorensen <Jes.Sorensen@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH v9 0/4] Introduce strtosz and make use of it
References: <1287674149-25418-1-git-send-email-Jes.Sorensen@redhat.com>
	<m3d3r2ejym.fsf@blackfin.pond.sub.org>
In-Reply-To: <m3d3r2ejym.fsf@blackfin.pond.sub.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: pbonzini@redhat.com, qemu-devel@nongnu.org

On 10/22/10 09:59, Markus Armbruster wrote:
> Jes.Sorensen@redhat.com writes:
>> From: Jes Sorensen <Jes.Sorensen@redhat.com>
>> This patch introduces cutils.c: strtosz() and gets rid of the
>> multiple custom hacks for parsing byte sizes. In addition it adds
>> supports for specifying human style sizes such as 1.5G. Last it
>> eliminates the horrible abuse of a float to store the byte size for
>> migrate_set_speed in the monitor.
>>
>> Note, this is tested on Linux and build tested for win32 using
>> mingw32.
>>
>> v9: I worked through a couple of revisions directly with Markus and I
>> think I got it right finally. 
> 
> I'd prefer to have strtosz() to match strtol() & friends and not
> restrict suffixes.  But this code does what it claims to do, as far as I
> can see, so:
> 
> ACK series

Thanks!

I thought about this a fair bit and I believe doing the full test in the
function is the most valuable. It's a personal preference obviously.
I think it's a win to do it here since it simplifies the caller code.

Would be great to get this applied so I can get it off my plate :)

Cheers,
Jes