From: Mathias Lafeldt <misfire@debugon.org>
To: git@vger.kernel.org
Subject: [PATCH 3/3] GIT-VERSION-GEN: style nitpicks
Date: Fri, 22 Oct 2010 13:24:29 +0200 [thread overview]
Message-ID: <4CC1746D.5070907@debugon.org> (raw)
In-Reply-To: <cover.1287746107.git.misfire@debugon.org>
- remove superfluous semicolon
- simplify version comparison
- remove empty lines at end of file
Signed-off-by: Mathias Lafeldt <misfire@debugon.org>
---
GIT-VERSION-GEN | 10 +++++-----
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/GIT-VERSION-GEN b/GIT-VERSION-GEN
index 427d5d6..60bef5a 100755
--- a/GIT-VERSION-GEN
+++ b/GIT-VERSION-GEN
@@ -18,7 +18,7 @@ elif test -d .git -o -f .git &&
v[0-9]*) : ;;
esac
then
- VN=$(echo "$VN" | sed -e 's/-/./g');
+ VN=$(echo "$VN" | sed -e 's/-/./g')
else
VN="$DEF_VER"
fi
@@ -31,9 +31,9 @@ then
else
VC=unset
fi
-test "$VN" = "$VC" || {
+
+if test "$VN" != "$VC"
+then
echo >&2 "GIT_VERSION = $VN"
echo "GIT_VERSION = $VN" >$GVF
-}
-
-
+fi
--
1.7.3.2
prev parent reply other threads:[~2010-10-22 11:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1287746107.git.misfire@debugon.org>
2010-10-22 11:24 ` [PATCH 1/3] GIT-VERSION-GEN: make use of git describe --dirty Mathias Lafeldt
2010-10-22 15:11 ` Jonathan Nieder
2010-10-23 12:23 ` Mathias Lafeldt
2010-10-27 7:50 ` Mathias Lafeldt
2010-10-27 14:28 ` Jakub Narebski
2010-10-22 11:24 ` [PATCH 2/3] GIT-VERSION-GEN: tweak processing of version file Mathias Lafeldt
2010-10-22 11:24 ` Mathias Lafeldt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CC1746D.5070907@debugon.org \
--to=misfire@debugon.org \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.