Re: [PATCH] hso: Set modem name based on udev network interface name

[Denis Kenzior <denkenz@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 806 bytes --]

Hi Benoît,

On 10/21/2010 03:26 AM, "Benoît Monin" wrote:
> Useful if you have multiple identical modems and you need a way
> to know which modem you're talking to.
> ---
>  plugins/udev.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/plugins/udev.c b/plugins/udev.c
> index 737a637..e687c01 100644
> --- a/plugins/udev.c
> +++ b/plugins/udev.c
> @@ -191,6 +191,7 @@ static void add_hso(struct ofono_modem *modem,
>         } else if (g_str_equal(subsystem, "net") == TRUE) {
>                 devnode = get_property(udev_device, "INTERFACE");
>                 ofono_modem_set_string(modem, NETWORK_INTERFACE, devnode);
> +               ofono_modem_set_name(modem, devnode);

I prefer you do this in plugins/hso and not in udev.

Regards,
-Denis