All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joe Eykholt <jeykholt-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
To: Hillf Danton <dhillf-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: devel-s9riP+hp16TNLxjTenLetw@public.gmane.org,
	linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] libfc: fix error handling in fc_exch_rrq_resp()
Date: Fri, 22 Oct 2010 11:57:51 -0700	[thread overview]
Message-ID: <4CC1DEAF.50403@cisco.com> (raw)
In-Reply-To: <AANLkTik3GbuiEGVPigGZp+=RH7qRMarn0cdZJ49Toso7-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>



On 10/22/10 8:21 AM, Hillf Danton wrote:
> There seems no cleanup left when FC_EX_CLOSED encountered, which may
> be from fc_exch_reset().

Are you sure?  It seems that the RRQ exchange has a hold on another
exchange, the one that's the subject of the RRQ.  That exchange
still needs to be released.  I could be wrong, it's been a while.

> Signed-off-by: Hillf Danton <dhillf-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
> 
> --- a/drivers/scsi/libfc/fc_exch.c	2010-09-13 07:07:38.000000000 +0800
> +++ b/drivers/scsi/libfc/fc_exch.c	2010-10-22 23:17:50.000000000 +0800
> @@ -1827,7 +1827,9 @@ static void fc_exch_rrq_resp(struct fc_s
>  	if (IS_ERR(fp)) {
>  		int err = PTR_ERR(fp);
> 
> -		if (err == -FC_EX_CLOSED || err == -FC_EX_TIMEOUT)
> +		if (err == -FC_EX_CLOSED)
> +			return;
> +		if (err == -FC_EX_TIMEOUT)
>  			goto cleanup;
>  		FC_EXCH_DBG(aborted_ep, "Cannot process RRQ, "
>  			    "frame error %d\n", err);
> _______________________________________________
> devel mailing list
> devel-s9riP+hp16TNLxjTenLetw@public.gmane.org
> http://www.open-fcoe.org/mailman/listinfo/devel

  parent reply	other threads:[~2010-10-22 18:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-22 15:21 [PATCH] libfc: fix error handling in fc_exch_rrq_resp() Hillf Danton
     [not found] ` <AANLkTik3GbuiEGVPigGZp+=RH7qRMarn0cdZJ49Toso7-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-10-22 18:57   ` Joe Eykholt [this message]
2010-10-23  7:56     ` [Open-FCoE] " Hillf Danton
     [not found]       ` <4CC521C7.4010001@cisco.com>
2010-10-25 13:16         ` Hillf Danton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CC1DEAF.50403@cisco.com \
    --to=jeykholt-fyb4gu1cfyuavxtiumwx3w@public.gmane.org \
    --cc=devel-s9riP+hp16TNLxjTenLetw@public.gmane.org \
    --cc=dhillf-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.