From: Mauro Carvalho Chehab <mchehab@redhat.com>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: David Ellingsworth <david@identd.dyndns.org>,
linux-media@vger.kernel.org
Subject: Re: [RFC PATCH] radio-mr800: locking fixes
Date: Fri, 22 Oct 2010 22:31:12 -0200 [thread overview]
Message-ID: <4CC22CD0.1090800@redhat.com> (raw)
In-Reply-To: <201010181751.39859.hverkuil@xs4all.nl>
Em 18-10-2010 13:51, Hans Verkuil escreveu:
> On Monday, October 18, 2010 16:55:40 David Ellingsworth wrote:
>> OK, I see how this fixes it now.. You added the video_is_registered
>> check inside v4l2_open after acquiring the device lock. So while it
>> fixes that race it's rather ugly and very difficult to follow. In this
>> case, the original code provided an easier to follow sequence. If
>> possible it would be nice if v4l2_open and v4l2_unlocked_ioctl relied
>> on the device being connected rather than registered. Then this would
>> have been a non-issue and it would be much easier to follow.
>
> I agree that it isn't the prettiest code. My goal is to improve the v4l
> core to make such cases easier to handle. But I'm waiting for the next
> kernel cycle before I continue with this.
>
> Working on this driver definitely helped give me a better understanding of
> what is involved.
>
> Regards,
>
Any conclusion about the locking fixes patch?
Cheers,
Mauro
next prev parent reply other threads:[~2010-10-23 0:31 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-17 12:26 [RFC PATCH] radio-mr800: locking fixes Hans Verkuil
2010-10-17 12:52 ` Hans Verkuil
2010-10-18 13:16 ` David Ellingsworth
2010-10-18 13:20 ` Hans Verkuil
2010-10-18 16:06 ` David Ellingsworth
2010-10-18 13:25 ` David Ellingsworth
2010-10-18 13:38 ` Hans Verkuil
2010-10-18 13:56 ` David Ellingsworth
2010-10-18 14:18 ` Hans Verkuil
2010-10-18 14:35 ` David Ellingsworth
2010-10-18 14:55 ` David Ellingsworth
2010-10-18 15:51 ` Hans Verkuil
2010-10-23 0:31 ` Mauro Carvalho Chehab [this message]
2010-10-23 1:21 ` David Ellingsworth
2010-10-18 13:38 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CC22CD0.1090800@redhat.com \
--to=mchehab@redhat.com \
--cc=david@identd.dyndns.org \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.