From: Jens Axboe <jaxboe@fusionio.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [BUG] disk_free_ptbl_rcu_cb() crash
Date: Sun, 24 Oct 2010 08:45:52 +0200 [thread overview]
Message-ID: <4CC3D620.2090401@fusionio.com> (raw)
In-Reply-To: <1287902670.2658.580.camel@edumazet-laptop>
On 2010-10-24 08:44, Eric Dumazet wrote:
> Le dimanche 24 octobre 2010 à 08:04 +0200, Jens Axboe a écrit :
>> On 2010-10-23 23:10, Eric Dumazet wrote:
>>> Current Linus tree makes my machine crash in disk_free_ptbl_rcu_cb(),
>>> while booting...
>>>
>>> commit 7681bfeeccff5ef seems the problem ?
>>>
>>> Following patch solves the NULL dereference, but this is only to show
>>> you where the problem is, not a real fix, of course.
>>
>> Darn. Your fix is on the right path, you missed one though. I think it's
>> cleaner to move this into the elevator helpers, so that the callers can
>> remain clean.
>>
>> Can you verify that this works too?
>
> Sure, I did right now and it works too, thanks !
Thanks for the (very) quick turn-around, I'll get this one expedited
as well.
--
Jens Axboe
next prev parent reply other threads:[~2010-10-24 6:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-23 21:10 [BUG] disk_free_ptbl_rcu_cb() crash Eric Dumazet
2010-10-24 6:04 ` Jens Axboe
2010-10-24 6:44 ` Eric Dumazet
2010-10-24 6:45 ` Jens Axboe [this message]
2010-10-24 6:52 ` Vivek Goyal
2010-10-24 7:00 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CC3D620.2090401@fusionio.com \
--to=jaxboe@fusionio.com \
--cc=eric.dumazet@gmail.com \
--cc=isimatu.yasuaki@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.