Re: [PATCH 3/4] fs: skip I_FREEING inodes in writeback_sb_inodes

[Christian Stroetmann <stroetmann@ontolinux.com>]

  little typos

On the 24.10.2010 19:40, Christoph Hellwig wrote:
> Skip I_FREEING inodes just like I_WILL_FREE and I_NEW when walking the
> writeback lists.  Currenly this can't happen, but once we move from
> inode_lock to more fine grained locking we can have an inode that's
> still on the writeback lists but has I_FREEING set, and we absolutely
> need to skip it here, just like we do for all other inode list walks.
>
> Based on a patch from Dave Chinner.
>
> Signed-off-by: Christoph Hellwig<hch@lst.de>
>
> Index: linux-2.6/fs/fs-writeback.c
> ===================================================================
> --- linux-2.6.orig/fs/fs-writeback.c	2010-10-24 13:21:18.282010741 +0200
> +++ linux-2.6/fs/fs-writeback.c	2010-10-24 13:21:35.456004735 +0200
> @@ -487,10 +487,16 @@ static int writeback_sb_inodes(struct su
>   			return 0;
>   		}
>
> -		if (inode->i_state&  (I_NEW | I_WILL_FREE)) {
> +		/*
> +		 * Don't bother with new inodes or inodes beeing freed, first
being
> +		 * kind does not need peridic writeout yet, and for the latter
> +		 * kind writeout is handled by the freer.
don't know:
freer inode
or
releaser

[...]