From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ARMV7: OMAP: I2C driver: Fix bug found in 37XX testing
Date: Mon, 25 Oct 2010 08:05:58 +0200 [thread overview]
Message-ID: <4CC51E46.80304@denx.de> (raw)
In-Reply-To: <1287780480.7756.352.camel@quadra>
Hello Steve,
Steve Sakoman wrote:
> On OMAP36/37XX the standard on chip pullups are not sufficient to
> ensure proper i2c operation without external pullups or switching
> to high speed mode and enabling special on chip pullups.
>
> This is an issue for Beagle xM, which does not have external pullups
> on the expansion board i2c lines.
>
> The issue manifests itself as an AL (arbitration lost) error when
> probing for a non-existent device (i.e. on a Beagle xM with no expansion
> boards attached). This issue does not occur on expansion boards that
> include pullups or on Overo 37XX COM's since they include pull-ups.
>
> This patch fixes the issue by checking for the AL bit in the i2c_probe
> function.
>
> Signed-off-by: Steve Sakoman <steve.sakoman@linaro.org>
> ---
Tested it here on my beagle board too, thanks!
Texas Instruments X-Loader 1.4.2 (Feb 19 2009 - 12:01:24)
U-Boot 2010.09-04580-g4df6689 (Oct 25 2010 - 07:57:35)
OMAP3530-GP ES3.0, CPU-OPP2, L3-165MHz, Max CPU Clock 600 mHz
OMAP3 Beagle board + LPDDR/NAND
I2C: ready
[...]
Applied to u-boot-i2c master
bye,
Heiko
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
prev parent reply other threads:[~2010-10-25 6:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-22 20:48 [U-Boot] [PATCH] ARMV7: OMAP: I2C driver: Fix bug found in 37XX testing Steve Sakoman
2010-10-25 6:05 ` Heiko Schocher [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CC51E46.80304@denx.de \
--to=hs@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.