From: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
To: Arnaldo Carvalho de Melo <acme@infradead.org>
Cc: Ingo Molnar <mingo@elte.hu>,
linux-kernel@vger.kernel.org,
Arnaldo Carvalho de Melo <acme@redhat.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
2nddept-manager@sdl.hitachi.co.jp
Subject: Re: [PATCH 5/5] perf probe: Fix format specified for Dwarf_Off parameter
Date: Mon, 25 Oct 2010 15:36:41 +0900 [thread overview]
Message-ID: <4CC52579.8020001@hitachi.com> (raw)
In-Reply-To: <1287865704-3880-6-git-send-email-acme@infradead.org>
(2010/10/24 5:28), Arnaldo Carvalho de Melo wrote:
> From: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> Fixing the following error on 32-bit arches:
>
> util/probe-finder.c: In function ‘line_range_search_cb’:
> util/probe-finder.c:1734: error: format ‘%lx’ expects type ‘long
> unsigned int’, but argument 3 has type ‘Dwarf_Off’
Oops, right. Thanks Arnaldo!
Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
>
> Reported-by: Ingo Molnar <mingo@elte.hu>
> Cc: Frederic Weisbecker <fweisbec@gmail.com>
> Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
> LKML-Reference: <new-submission>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> ---
> tools/perf/util/probe-finder.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/tools/perf/util/probe-finder.c b/tools/perf/util/probe-finder.c
> index c20bd52..3991d73 100644
> --- a/tools/perf/util/probe-finder.c
> +++ b/tools/perf/util/probe-finder.c
> @@ -1731,7 +1731,8 @@ static int line_range_search_cb(Dwarf_Die *sp_die, void *data)
> struct line_finder *lf = param->data;
> struct line_range *lr = lf->lr;
>
> - pr_debug("find (%lx) %s\n", dwarf_dieoffset(sp_die),
> + pr_debug("find (%llx) %s\n",
> + (unsigned long long)dwarf_dieoffset(sp_die),
> dwarf_diename(sp_die));
> if (dwarf_tag(sp_die) == DW_TAG_subprogram &&
> die_compare_name(sp_die, lr->function)) {
--
Masami HIRAMATSU
2nd Dept. Linux Technology Center
Hitachi, Ltd., Systems Development Laboratory
E-mail: masami.hiramatsu.pt@hitachi.com
next prev parent reply other threads:[~2010-10-25 6:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-23 20:28 [GIT PULL 0/5] perf/core improvements and fixes Arnaldo Carvalho de Melo
2010-10-23 20:28 ` [PATCH 1/5] perf tools: Remove direct slang.h include Arnaldo Carvalho de Melo
2010-10-23 20:28 ` [PATCH 2/5] perf tools: Document event modifiers Arnaldo Carvalho de Melo
2010-10-23 20:28 ` [PATCH 3/5] perf trace: Use $PERF_EXEC_PATH in canned report scripts Arnaldo Carvalho de Melo
2010-10-23 20:28 ` [PATCH 4/5] perf trace: Fix detection of script extension Arnaldo Carvalho de Melo
2010-10-23 20:28 ` [PATCH 5/5] perf probe: Fix format specified for Dwarf_Off parameter Arnaldo Carvalho de Melo
2010-10-25 6:35 ` Masami Hiramatsu
2010-10-25 6:36 ` Masami Hiramatsu [this message]
2010-10-24 9:39 ` [GIT PULL 0/5] perf/core improvements and fixes Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CC52579.8020001@hitachi.com \
--to=masami.hiramatsu.pt@hitachi.com \
--cc=2nddept-manager@sdl.hitachi.co.jp \
--cc=acme@infradead.org \
--cc=acme@redhat.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.