From mboxrd@z Thu Jan 1 00:00:00 1970 From: Zdenek Kabelac Date: Mon, 25 Oct 2010 12:59:42 +0200 Subject: [PATCH 02/30] Use dm_pool_grow_object embeded strlen for 0 delta In-Reply-To: <87vd4q61el.wl%ejt@redhat.com> References: <87vd4q61el.wl%ejt@redhat.com> Message-ID: <4CC5631E.9040204@redhat.com> List-Id: To: lvm-devel@redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Dne 25.10.2010 11:56, ejt at redhat.com napsal(a): > At Mon, 25 Oct 2010 10:24:09 +0200, > Zdenek Kabelac wrote: >> >> Use internal strlen for 0 >> >> Signed-off-by: Zdenek Kabelac > > Ack, but I don't think this improves the readablility of the code. The problem is the extra semantics of zero as the third arg to dm_pool_grow_object() (probably my bad). Maybe introduce a new pool method dm_pool_grow_string(struct dm_pool *p, const char *str) ? Well you are not the first one with this idea :) Me and Milan thinks in the same way - if everyone agree - I'll make another version with ...grow_string() Zdenek