From mboxrd@z Thu Jan 1 00:00:00 1970 From: Zdenek Kabelac Date: Mon, 25 Oct 2010 13:17:05 +0200 Subject: [PATCH 16/30] Fix void* pointer arithmetic In-Reply-To: <87fwvu60ai.wl%ejt@redhat.com> References: <87fwvu60ai.wl%ejt@redhat.com> Message-ID: <4CC56731.1070600@redhat.com> List-Id: To: lvm-devel@redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Dne 25.10.2010 12:20, ejt at redhat.com napsal(a): > At Mon, 25 Oct 2010 10:24:23 +0200, > Zdenek Kabelac wrote: >> >> >> Signed-off-by: Zdenek Kabelac > > Nack. No explanation. eg, Are we deprecating the void pointer arithmetic gcc extension? void* arithmetic is IMHO bad practice and we should avoid it's usage. char* clearly defines 1byte - I'd prefer to use standard C whenever we can. (And gcc can show this as warning - so why not fixing it) Zdenek