From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: [Qemu-devel] Re: [PATCH 0/2] Type-safe ioport callbacks Date: Mon, 25 Oct 2010 09:04:57 -0500 Message-ID: <4CC58E89.4090001@codemonkey.ws> References: <1287934469-16624-1-git-send-email-avi@redhat.com> <4CC46E73.2090704@redhat.com> <4CC46F22.7070202@redhat.com> <4CC58A48.6070204@codemonkey.ws> <4CC58BAB.4090808@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Avi Kivity , qemu-devel@nongnu.org, kvm@vger.kernel.org To: Paolo Bonzini Return-path: Received: from mail-iw0-f174.google.com ([209.85.214.174]:59446 "EHLO mail-iw0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751238Ab0JYOE7 (ORCPT ); Mon, 25 Oct 2010 10:04:59 -0400 Received: by iwn10 with SMTP id 10so857046iwn.19 for ; Mon, 25 Oct 2010 07:04:59 -0700 (PDT) In-Reply-To: <4CC58BAB.4090808@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 10/25/2010 08:52 AM, Paolo Bonzini wrote: > On 10/25/2010 03:46 PM, Anthony Liguori wrote: >>>> >>>> Should we create a Documentation/ file with incomplete transitions >>>> and the commit(s) that introduced them, for volunteers who wish to do >>>> some dirty work or to learn Coccinelle? >>> >>> If we have a TODO, we could add a janitor section there. >> >> That's unnecessary work. The vast majority of the callers of >> register_ioport* should be using a bus specific interface instead. > > It's still an incomplete transition. Right, but what I meant was, there's not a lot of benefit to switching callers to ioport_register() if they should be using isa_ioport_register() or whatever is the appropriate interface. Regards, Anthony Liguori > Paolo From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=60335 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PANfZ-0007m8-Io for qemu-devel@nongnu.org; Mon, 25 Oct 2010 10:05:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PANfY-0002BF-8J for qemu-devel@nongnu.org; Mon, 25 Oct 2010 10:05:01 -0400 Received: from mail-iw0-f173.google.com ([209.85.214.173]:48023) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PANfY-0002BB-40 for qemu-devel@nongnu.org; Mon, 25 Oct 2010 10:05:00 -0400 Received: by iwn36 with SMTP id 36so4847444iwn.4 for ; Mon, 25 Oct 2010 07:04:59 -0700 (PDT) Message-ID: <4CC58E89.4090001@codemonkey.ws> Date: Mon, 25 Oct 2010 09:04:57 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] Re: [PATCH 0/2] Type-safe ioport callbacks References: <1287934469-16624-1-git-send-email-avi@redhat.com> <4CC46E73.2090704@redhat.com> <4CC46F22.7070202@redhat.com> <4CC58A48.6070204@codemonkey.ws> <4CC58BAB.4090808@redhat.com> In-Reply-To: <4CC58BAB.4090808@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Avi Kivity , kvm@vger.kernel.org, qemu-devel@nongnu.org On 10/25/2010 08:52 AM, Paolo Bonzini wrote: > On 10/25/2010 03:46 PM, Anthony Liguori wrote: >>>> >>>> Should we create a Documentation/ file with incomplete transitions >>>> and the commit(s) that introduced them, for volunteers who wish to do >>>> some dirty work or to learn Coccinelle? >>> >>> If we have a TODO, we could add a janitor section there. >> >> That's unnecessary work. The vast majority of the callers of >> register_ioport* should be using a bus specific interface instead. > > It's still an incomplete transition. Right, but what I meant was, there's not a lot of benefit to switching callers to ioport_register() if they should be using isa_ioport_register() or whatever is the appropriate interface. Regards, Anthony Liguori > Paolo