From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steve Wise Subject: Re: [PATCH v2] RDMA/cxgb3: When a user QP is marked in error, also mark the CQs in error. Date: Mon, 25 Oct 2010 09:15:21 -0500 Message-ID: <4CC590F9.7010608@opengridcomputing.com> References: <20101021123705.7604.20848.stgit@build.ogc.int> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Roland Dreier Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-rdma@vger.kernel.org On 10/23/2010 12:07 AM, Roland Dreier wrote: > I applied this, but can you check if there are any alignment/size issues > with 32-bit userspace on 64-bit kernel? Specifically: > > > struct iwch_create_cq_resp { > > __u64 key; > > __u32 cqid; > > __u32 size_log2; > > + __u32 memsize; > > }; > > this structure now has size 20 on i386 (32-bit) but size 24 on x86-64 I > think so a 64-bit kernel might falsely think that the 32-bit library was > old. > > The fix is to add a __u32 reserved field at the end of the struct so it > always gets padded to 24 bytes. But I don't want to do that to this > patch until you change the userspace library too. > Good catch Roland. Is there an easy way to configure/build libibverbs and librdmacm as 32bit? My system only has the 64b versions. So I'll need to build 32b versions of these to test my fix with a 32b app / 64b kernel. Steve. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html