All of lore.kernel.org
 help / color / mirror / Atom feed
From: "J.H." <warthog19@eaglescrag.net>
To: Bron Gondwana <brong@fastmail.fm>
Cc: git@vger.kernel.org, pape@smarden.org
Subject: Re: Why /var/cache/git?
Date: Mon, 25 Oct 2010 08:24:47 -0700	[thread overview]
Message-ID: <4CC5A13F.2090702@eaglescrag.net> (raw)
In-Reply-To: <20101025103006.GA18782@brong.net>

On 10/25/2010 03:30 AM, Bron Gondwana wrote:
> (resent - correct address for git list!)
> 
> (Gerrit: you're CC'd as the attribution in README.Debian
>  which in the one place I can see /var/cache/git mentioned
>  in the docs - without a justification for why it was
>  chosen...)

Couple of quick points:

$ grep -Ri "/var/git\|\/var\/git" *
Documentation/git-cvsserver.txt:     export
CVSROOT=:ext:user@server:/var/git/project.git

gitweb/README:    RewriteRule ^/var(/|/gitweb.cgi)?$	
/cgi-bin/gitweb.cgi [QSA,E=GITWEB_PROJECTROOT:/var/git/,L,PT]

gitweb/README:Second, repositories found in /pub/scm/ and /var/git/ will
be accesible

Are the only 3 instances where this is mentioned.  Looking at those
quick it was probably chosen based on the fact that it's a location that
likely exists on most machines.  Or just for explanatory reasons like
/example/dir/project.git could be used.

> I'm setting up shared repositories on a machine, and I notice
> all the examples I can find on the web, and also the 
> auto-created directory from the packages are /var/cache/git/

I can't speak for the web, it's a place filled with many many evil dirty
lies, but the primary documentation should likely get updated to not
actually shove perminant data into a transient location.  Bonus that
gitweb (caching) might use the directory for it's cache storage which
could cause some amusement.

> 
> So I looked at the FHS, because that seemed odd to me:
[...]
> I guess in theory, someone else has all those commits in their
> local git repository somewhere.  Still, it feels to me that
> /var/lib/git is the correct location.  Is there any reason why
> /var/spool/git was chosen?

Ummmm are you talking about for where a set of repositories exist on a
shared setup?  Personally, and depending on your beliefs as a sysadmin,
it should likely end up under something like /home/git or some other
shared location like /group/git, /pub/git, /shared/git or really
anywhere where you are likely to do backups and not just run rm -rf
because it should be a transient location.

> (I'm running Debian Lenny with the 1.7.1 backport packages, but
> I see examples from Fedora with the same paths as well)

Speaking from the Fedora angle (since I don't have a Debian box handy
anywhere or in a VM) the only places I'm seeing /var/git mentioned is:

/usr/share/doc/git-1.7.2.3/git-cvsserver.txt
/usr/share/doc/git-1.7.2.3/git-cvsserver.html
/usr/share/doc/git-cvs-1.7.2.3/git-cvsserver.txt
/usr/share/doc/git-cvs-1.7.2.3/git-cvsserver.html
/usr/share/doc/git-cvs-1.7.2.3/git-cvsserver.html
/usr/share/doc/gitweb-1.7.2.3/README
/usr/share/doc/gitweb-caching-1.6.5.2/README

which are the latest versions of all of those packages and it's obvious
it's the git-cvs and gitweb stuff that are to blame for the confusion there.

Probably easiest thing to do is adjust the documentation to be
/example/dir/project.git vs. /var/git since I agree, that's actually
dangerous.

- John 'Warthog9' Hawley

  reply	other threads:[~2010-10-25 15:30 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-25 10:30 Why /var/cache/git? Bron Gondwana
2010-10-25 15:24 ` J.H. [this message]
2010-10-26  1:22   ` Bron Gondwana
2010-10-26 13:21     ` Drew Northup
2010-10-26 15:22       ` Gerrit Pape
2010-10-26 16:47         ` Jakub Narebski
2010-10-26 18:30         ` Junio C Hamano
2010-10-28 15:53           ` Gerrit Pape
2010-10-26 20:58         ` Bron Gondwana

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CC5A13F.2090702@eaglescrag.net \
    --to=warthog19@eaglescrag.net \
    --cc=brong@fastmail.fm \
    --cc=git@vger.kernel.org \
    --cc=pape@smarden.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.