Re: [PATCH] netfilter: remove modulo operations

[Patrick McHardy <kaber@trash.net>]

Am 25.10.2010 11:26, schrieb Eric Dumazet:
> Le dimanche 24 octobre 2010 à 11:40 +0800, Changli Gao a écrit :
>> Signed-off-by: Changli Gao <xiaosuo@gmail.com>
>> ---
>>  net/netfilter/xt_NFQUEUE.c |    6 ++++--
>>  1 file changed, 4 insertions(+), 2 deletions(-)
>> diff --git a/net/netfilter/xt_NFQUEUE.c b/net/netfilter/xt_NFQUEUE.c
>> index 039cce1..3962770 100644
>> --- a/net/netfilter/xt_NFQUEUE.c
>> +++ b/net/netfilter/xt_NFQUEUE.c
>> @@ -72,10 +72,12 @@ nfqueue_tg_v1(struct sk_buff *skb, const struct xt_action_param *par)
>>  
>>  	if (info->queues_total > 1) {
>>  		if (par->family == NFPROTO_IPV4)
>> -			queue = hash_v4(skb) % info->queues_total + queue;
>> +			queue = (((u64) hash_v4(skb) * info->queues_total) >>
>> +				 32) + queue;
>>  #if defined(CONFIG_IP6_NF_IPTABLES) || defined(CONFIG_IP6_NF_IPTABLES_MODULE)
>>  		else if (par->family == NFPROTO_IPV6)
>> -			queue = hash_v6(skb) % info->queues_total + queue;
>> +			queue = (((u64) hash_v6(skb) * info->queues_total) >>
>> +				 32) + queue;
>>  #endif
>>  	}
>>  	return NF_QUEUE_NR(queue);
> 
> 
> Acked-by: Eric Dumazet <eric.dumazet@gmail.com>

This looks fine to me, however I'm currently only taking bugfixes.
Please resend once net-next opens up for new patches again.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html