All of lore.kernel.org
 help / color / mirror / Atom feed
From: jason77.wang@gmail.com (Jason Wang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/4] mx31_3ds: Fix the logic for detecting the debug board
Date: Tue, 26 Oct 2010 10:14:02 +0800	[thread overview]
Message-ID: <4CC6396A.20208@gmail.com> (raw)
In-Reply-To: <AANLkTikg5rM+cp6oJXmW=DE5=FV=drycqvhz0xWAf1by@mail.gmail.com>

Acked-by: Jason Wang <jason77.wang@gmail.com>

Rogerio Pimentel wrote:
> The function mxc_expio_init returns 0 on success, so fix the logic for
> printing the error case.
> Also fixed the wording on the error message.
>
>  Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
>  Signed-off-by: Rogerio Pimentel <rogerio.pimentel@freescale.com>
>
> ---
>  arch/arm/mach-mx3/mach-mx31_3ds.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/mach-mx3/mach-mx31_3ds.c
> b/arch/arm/mach-mx3/mach-mx31_3ds.c
> index bc21efc..005c0b2 100644
> --- a/arch/arm/mach-mx3/mach-mx31_3ds.c
> +++ b/arch/arm/mach-mx3/mach-mx31_3ds.c
> @@ -251,9 +251,9 @@ static void __init mxc_board_init(void)
>  	mx31_3ds_usbotg_init();
>  	mxc_register_device(&mxc_otg_udc_device, &usbotg_pdata);
>
> -	if (!mxc_expio_init(CS5_BASE_ADDR, EXPIO_PARENT_INT))
> -		printk(KERN_WARNING "Init of the debugboard failed, all "
> -				    "devices on the board are unusable.\n");
> +	if (mxc_expio_init(CS5_BASE_ADDR, EXPIO_PARENT_INT))
> +		printk(KERN_WARNING "Init of the debug board failed, all "
> +				    "devices on the debug board are unusable.\n");
>  }
>
>  static void __init mx31_3ds_timer_init(void)
>   

      reply	other threads:[~2010-10-26  2:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-25 14:54 [PATCH 2/4] mx31_3ds: Fix the logic for detecting the debug board Rogerio Pimentel
2010-10-26  2:14 ` Jason Wang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CC6396A.20208@gmail.com \
    --to=jason77.wang@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.