From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Schocher Date: Tue, 26 Oct 2010 10:40:30 +0200 Subject: [U-Boot] [PATCH 1/2] mx51evk: support new relocation scheme In-Reply-To: <4CC692A9.2080800@denx.de> References: <1288019681-18496-1-git-send-email-shawn.gsc@gmail.com> <1288019681-18496-2-git-send-email-shawn.gsc@gmail.com> <4CC68A6B.1030302@denx.de> <4CC68DD6.6030506@denx.de> <4CC69072.9010403@denx.de> <4CC692A9.2080800@denx.de> Message-ID: <4CC693FE.4090500@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello Stefano, Stefano Babic wrote: > On 10/26/2010 10:25 AM, Heiko Schocher wrote: >> Hello Stefano, >> >> Stefano Babic wrote: >>> On 10/26/2010 10:05 AM, Shawn Guo wrote: >>>> Hi Stefano, >>>> >>>> On Tue, Oct 26, 2010 at 3:59 PM, Stefano Babic wrote: >>>>> On 10/25/2010 05:14 PM, Shawn Guo wrote: >>>>> >>>>>> +#define CONFIG_SYS_SDRAM_BASE PHYS_SDRAM_1 >>>>>> +#define CONFIG_SYS_INIT_SP_ADDR (IRAM_BASE_ADDR + 0x1000) >>>>> What is the meaning of the offset at 0x1000 ? Is there something at >>>>> IRAM_BASE_ADDR ? >>>>> >>>> I thought CONFIG_SYS_INIT_SP_ADDR is assigned to stack pointer (sp) >>>> which decrease the address. Is it not the case? >>>> >>> Yes, my doubt is due to the fact that we do not set the SP at the end of >>> the IRAM and we set it to an arbitrary address in between. >> We should set the CONFIG_SYS_INIT_SP_ADDR @ (IRAM_BASE_ADDR + IRAM_BASE_SIZE >> - CONFIG_SYS_GBL_DATA_SIZE) > > Agree, this is what I set for the vision2 board. We should be consistent > and do the same for the mx51evk. Yep. >> Don;t know if IRAM_BASE_SIZE exists ... > > we must define it. I set it in the board configuration file, but it is > wrong. The value should be moved into register definition file for the > SoC (imx-regs.h) Full-Ack. This is a SoC define, not board dependend. bye, Heiko -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany