All of lore.kernel.org
 help / color / mirror / Atom feed
From: Reinhard Meyer <u-boot@emk-elektronik.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V2] imx25: Fix reset
Date: Tue, 26 Oct 2010 11:27:51 +0200	[thread overview]
Message-ID: <4CC69F17.3050205@emk-elektronik.de> (raw)
In-Reply-To: <1288084626-25766-1-git-send-email-weisserm@arcor.de>

Dear Matthias Weisser,
> This patch fixes the reset command on imx25
> 
> Signed-off-by: Matthias Weisser <weisserm@arcor.de>
> +	writew(0x00000000, &regs->wcr);
> +	writew(0x00005555, &regs->wsr);
> +	writew(0x0000AAAA, &regs->wsr);

It might be "nicer" to use 16 Bit constants (with 4 hex digits)
here..?

Best Regards,
Reinhard

  reply	other threads:[~2010-10-26  9:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-26  9:17 [U-Boot] [PATCH V2] imx25: Fix reset Matthias Weisser
2010-10-26  9:27 ` Reinhard Meyer [this message]
2010-10-26 11:39   ` Matthias Weißer
2010-10-26 16:44     ` Jason Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CC69F17.3050205@emk-elektronik.de \
    --to=u-boot@emk-elektronik.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.